]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ansible.git/commitdiff
validate: fix check_devices v3.2.58
authorGuillaume Abrioux <gabrioux@redhat.com>
Tue, 29 Mar 2022 13:56:30 +0000 (15:56 +0200)
committerGuillaume Abrioux <gabrioux@redhat.com>
Tue, 29 Mar 2022 14:16:26 +0000 (16:16 +0200)
This fixes a regression introduced in 3.2.57 and the check_devices step.

When lvm_volumes is defined with data and data_vg (vg/lv format) it goes
to the second part of the condition which throws an undefined error given
that `devices` isn't defined.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2069491
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
roles/ceph-validate/tasks/check_devices.yml

index 4afb3dcf6267351f4d780b330fefdc940491c92e..ca9ded68c9066a235489e60ee71f467f17d9b011 100644 (file)
@@ -65,7 +65,7 @@
       with_items: "{{ lvm_volumes | default(devices) }}"
       when:
         - inventory_hostname in groups.get(osd_group_name, [])
-        - (item.data is defined and item.data_vg is undefined) or devices is defined
+        - (item.data is defined and item.data_vg is undefined) or devices | default([]) | length > 0
 
     - name: fail when gpt header found on osd devices
       fail: