]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commitdiff
veristat: Fix a memory leak for preset ENUMERATOR
authorIhor Solodrai <ihor.solodrai@linux.dev>
Mon, 23 Feb 2026 19:07:28 +0000 (11:07 -0800)
committerAlexei Starovoitov <ast@kernel.org>
Tue, 24 Feb 2026 16:19:49 +0000 (08:19 -0800)
ASAN detected a memory leak in veristat. The cleanup code handling
ENUMERATOR value missed freeing strdup-ed svalue. Fix it.

Acked-by: Mykyta Yatsenko <yatsenko@meta.com>
Signed-off-by: Ihor Solodrai <ihor.solodrai@linux.dev>
Link: https://lore.kernel.org/r/20260223190736.649171-13-ihor.solodrai@linux.dev
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/testing/selftests/bpf/veristat.c

index 1be1e353d40a7b988d84539ec75b7f1666b0bc76..75f85e0362f529cc74426daab58ab443356e439d 100644 (file)
@@ -3378,6 +3378,8 @@ int main(int argc, char **argv)
                        }
                }
                free(env.presets[i].atoms);
+               if (env.presets[i].value.type == ENUMERATOR)
+                       free(env.presets[i].value.svalue);
        }
        free(env.presets);
        return -err;