]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commitdiff
cache: fix clang override unhappiness. wip-cache-pri-usage
authorMark Nelson <mnelson@redhat.com>
Wed, 18 Apr 2018 20:50:16 +0000 (15:50 -0500)
committerMark Nelson <mnelson@redhat.com>
Mon, 14 May 2018 22:48:52 +0000 (17:48 -0500)
Signed-off-by: Mark Nelson <mnelson@redhat.com>
cache/lru_cache.h
cache/sharded_cache.h

index 9a6837e69da394928f0aecbe1168b7ab4b4600ab..1744d6edcc753a073138b43dc80ca30aacf739dc 100644 (file)
@@ -298,10 +298,10 @@ class LRUCache : public ShardedCache {
   virtual size_t GetCharge(Handle* handle) const override;
   virtual uint32_t GetHash(Handle* handle) const override;
   virtual void DisownData() override;
-  virtual size_t GetHighPriPoolCapacity() const;
-  virtual size_t GetHighPriPoolUsage() const;
-  virtual double GetHighPriPoolRatio() const;
-  virtual void SetHighPriPoolRatio(double high_pri_pool_ratio);
+  virtual size_t GetHighPriPoolCapacity() const override;
+  virtual size_t GetHighPriPoolUsage() const override;
+  virtual double GetHighPriPoolRatio() const override;
+  virtual void SetHighPriPoolRatio(double high_pri_pool_ratio) override;
   // Retrieves number of elements in LRU, for unit test purpose only
   size_t TEST_GetLRUSize();
 
index 4f9dea2ad0fe670ad68b1374a418ece3eca6915a..54d0c3778a779c0a7d69d225104f51808a0ca6c9 100644 (file)
@@ -59,7 +59,7 @@ class ShardedCache : public Cache {
 
   virtual void SetCapacity(size_t capacity) override;
   virtual void SetStrictCapacityLimit(bool strict_capacity_limit) override;
-
+  virtual void SetHighPriPoolRatio(double high_pri_pool_ratio) override = 0;
   virtual Status Insert(const Slice& key, void* value, size_t charge,
                         void (*deleter)(const Slice& key, void* value),
                         Handle** handle, Priority priority) override;
@@ -69,10 +69,14 @@ class ShardedCache : public Cache {
   virtual void Erase(const Slice& key) override;
   virtual uint64_t NewId() override;
   virtual size_t GetCapacity() const override;
+  virtual size_t GetHighPriPoolCapacity() const override = 0;
   virtual bool HasStrictCapacityLimit() const override;
   virtual size_t GetUsage() const override;
   virtual size_t GetUsage(Handle* handle) const override;
   virtual size_t GetPinnedUsage() const override;
+  virtual size_t GetHighPriPoolUsage() const override = 0;
+  virtual double GetHighPriPoolRatio() const override = 0;
+
   virtual void ApplyToAllCacheEntries(void (*callback)(void*, size_t),
                                       bool thread_safe) override;
   virtual void EraseUnRefEntries() override;