]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
librbd: restore readonly image check in snap_remove() wip-rbd-cgsm-base
authorPrasanna Kumar Kalever <prasanna.kalever@redhat.com>
Fri, 5 Dec 2025 11:46:33 +0000 (17:16 +0530)
committerPrasanna Kumar Kalever <prasanna.kalever@redhat.com>
Wed, 21 Jan 2026 11:04:22 +0000 (16:34 +0530)
The check preventing snapshot removal on read-only images was previously
commented out. This commit restores the original behavior to ensure that
snap_remove() correctly rejects operations on images that are not writable

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
src/librbd/Operations.cc

index 7fb76fd8a60bcc94d24a6de01be5fd244671891b..f233c642287264eaddd7b7a764d2e1d772842554 100644 (file)
@@ -1033,10 +1033,10 @@ void Operations<I>::snap_remove(const cls::rbd::SnapshotNamespace& snap_namespac
   ldout(cct, 5) << this << " " << __func__ << ": snap_name=" << snap_name
                 << dendl;
 
-  //if (m_image_ctx.read_only) {
-  //  on_finish->complete(-EROFS);
-  //  return;
-  //}
+  if (m_image_ctx.read_only) {
+    on_finish->complete(-EROFS);
+    return;
+  }
 
   // quickly filter out duplicate ops
   m_image_ctx.image_lock.lock_shared();