]> git-server-git.apps.pok.os.sepia.ceph.com Git - teuthology.git/commitdiff
nuke: drop remove_kernel_mounts() 1022/head
authorIlya Dryomov <idryomov@gmail.com>
Wed, 1 Feb 2017 19:37:49 +0000 (20:37 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Wed, 1 Feb 2017 20:26:45 +0000 (21:26 +0100)
Calling remove_kernel_mounts() after reboot() is pretty useless.  Also,
as explained in the previous commit, there isn't much we can do in the
krbd case, so just drop it.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
teuthology/nuke/__init__.py
teuthology/nuke/actions.py

index 502a694b1084997cb090f512b63968548d3cb9e8..733a6e6dec02cc194898e704e3273728656784cf 100644 (file)
@@ -25,7 +25,7 @@ from ..task.internal import check_lock, add_remotes, connect
 from .actions import (
     check_console, clear_firewall, shutdown_daemons, remove_installed_packages,
     reboot, remove_osd_mounts, remove_osd_tmpfs, kill_hadoop,
-    remove_kernel_mounts, remove_ceph_packages, synch_clocks,
+    remove_ceph_packages, synch_clocks,
     unlock_firmware_repo, remove_configuration_files, undo_multipath,
     reset_syslog_dir, remove_ceph_data, remove_testing_tree,
     remove_yum_timedhosts, kill_valgrind,
@@ -329,7 +329,6 @@ def nuke_helper(ctx, should_unlock):
     remove_osd_mounts(ctx)
     remove_osd_tmpfs(ctx)
     kill_hadoop(ctx)
-    remove_kernel_mounts(ctx)
     remove_ceph_packages(ctx)
     synch_clocks(remotes)
     unlock_firmware_repo(ctx)
index d3a3a53d5e69ef5f720b0406c5871db913d161f9..de3ed28d1aacbf17e3ac76feb4401d38f4a6ed60 100644 (file)
@@ -95,25 +95,6 @@ def kill_valgrind(ctx):
     )
 
 
-def remove_kernel_mounts(ctx):
-    """
-    properly we should be able to just do a forced unmount,
-    but that doesn't seem to be working, so you should reboot instead
-    """
-    log.info("Removing kernel mounts...")
-    ctx.cluster.run(
-        args=[
-            'grep', 'ceph', '/etc/mtab', run.Raw('|'),
-            'grep', '-o', "on /.* type", run.Raw('|'),
-            'grep', '-o', "/.* ", run.Raw('|'),
-            'xargs', '-r',
-            'sudo', 'umount', '-f', run.Raw(';'),
-        ],
-        check_status=False,
-        timeout=60
-    )
-
-
 def remove_osd_mounts(ctx):
     """
     unmount any osd data mounts (scratch disks)