]> git-server-git.apps.pok.os.sepia.ceph.com Git - teuthology.git/commitdiff
task/kernel.py: should pass args with name 1430/head
authorKefu Chai <kchai@redhat.com>
Fri, 27 Mar 2020 12:41:12 +0000 (20:41 +0800)
committerKefu Chai <kchai@redhat.com>
Fri, 27 Mar 2020 12:41:14 +0000 (20:41 +0800)
to address the failure of

```
Traceback (most recent call last):
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/run_tasks.py", line 86, in run_tasks
    manager = run_one_task(taskname, ctx=ctx, config=config)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/run_tasks.py", line 65, in run_one_task
    return task(**kwargs)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/task/kernel.py", line 1326, in task
    install_and_reboot(ctx, need_install)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/task/kernel.py", line 505, in install_and_reboot
    install_kernel(role_remote, remote_pkg_path(role_remote))
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/task/kernel.py", line 834, in install_kernel
    version = get_image_version(remote, path)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/task/kernel.py", line 1013, in get_image_version
    files = remote.run(['rpm', '-qlp', path])
TypeError: run() takes exactly 1 argument (2 given)
```

Signed-off-by: Kefu Chai <kchai@redhat.com>
teuthology/task/kernel.py

index 0035a63d37138d400f196b4463809f6def3c335c..aff4c40322262a016083ff027ee72822e4cc2c7a 100644 (file)
@@ -1010,9 +1010,9 @@ def get_image_version(remote, path):
     :param path: (rpm or deb) package path
     """
     if remote.os.package_type == 'rpm':
-        files = remote.run(['rpm', '-qlp', path])
+        files = remote.run(args=['rpm', '-qlp', path])
     elif remote.os.package_type == 'deb':
-        files = remote.run(['dpkg-deb', '-c', path])
+        files = remote.run(args=['dpkg-deb', '-c', path])
     else:
         raise UnsupportedPackageTypeError(remote)