iscsi: fix wrong group name for iscsi

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1498490
Signed-off-by: Sébastien Han <seb@redhat.com>

diff --git a/group_vars/all.yml.sample b/group_vars/all.yml.sample
index 22110f879b4f5c16c40592d8b845b987808154df..d79d71c9b95486aa8de61c0f6400aae068fc080c 100644 (file)
--- a/group_vars/all.yml.sample
+++ b/group_vars/all.yml.sample
@@ -51,7 +51,7 @@ dummy:
 #restapi_group_name: restapis
 #rbdmirror_group_name: rbdmirrors
 #client_group_name: clients
-#iscsi_gw_group_name: iscsi_gws
+#iscsi_gw_group_name: iscsi-gws
 #mgr_group_name: mgrs
 
 # If check_firewall is true, then ansible will try to determine if the

diff --git a/group_vars/rhcs.yml.sample b/group_vars/rhcs.yml.sample
index 5ba40b7fc20512f151f0a7b1041bdd05fda1894c..ea5c849a494328fdfecfc36360d99e7e813eeacc 100644 (file)
--- a/group_vars/rhcs.yml.sample
+++ b/group_vars/rhcs.yml.sample
@@ -51,7 +51,7 @@ fetch_directory: ~/ceph-ansible-keys
 #restapi_group_name: restapis
 #rbdmirror_group_name: rbdmirrors
 #client_group_name: clients
-#iscsi_gw_group_name: iscsi_gws
+#iscsi_gw_group_name: iscsi-gws
 #mgr_group_name: mgrs
 
 # If check_firewall is true, then ansible will try to determine if the

diff --git a/infrastructure-playbooks/purge-cluster.yml b/infrastructure-playbooks/purge-cluster.yml
index 578b22d229285bfb1d6320d2eef9a8d93812e24c..3216ea0e4f0baa77ff4181d1e107f0fe637a464b 100644 (file)
--- a/infrastructure-playbooks/purge-cluster.yml
+++ b/infrastructure-playbooks/purge-cluster.yml
@@ -509,7 +509,7 @@
     igw_purge_type: all
 
   hosts:
-    - "{{ iscsi_gw_group_name|default('iscsi-gw') }}"
+    - "{{ iscsi_gw_group_name|default('iscsi-gws') }}"
 
   gather_facts: false # already gathered previously
 

diff --git a/roles/ceph-defaults/defaults/main.yml b/roles/ceph-defaults/defaults/main.yml
index 20a31d3e749a350a9076cecb7daa9b42ea6b583a..5d38348c873a2e0e6d4f7a7bd22379949c3ffd84 100644 (file)
--- a/roles/ceph-defaults/defaults/main.yml
+++ b/roles/ceph-defaults/defaults/main.yml
@@ -43,7 +43,7 @@ nfs_group_name: nfss
 restapi_group_name: restapis
 rbdmirror_group_name: rbdmirrors
 client_group_name: clients
-iscsi_gw_group_name: iscsi_gws
+iscsi_gw_group_name: iscsi-gws
 mgr_group_name: mgrs
 
 # If check_firewall is true, then ansible will try to determine if the

diff --git a/roles/ceph-iscsi-gw/tasks/generate_crt.yml b/roles/ceph-iscsi-gw/tasks/generate_crt.yml
index db53acbaae9756d9a2fb9c45e03e3b3d2f35b551..067e631de1676706ac193f8cf53fca96d73acea6 100644 (file)
--- a/roles/ceph-iscsi-gw/tasks/generate_crt.yml
+++ b/roles/ceph-iscsi-gw/tasks/generate_crt.yml
@@ -1,16 +1,16 @@
 ---
-- name: (local) create ssl crt/key files
+- name: create ssl crt/key files
   shell: |
     openssl req -newkey rsa:2048 -nodes -keyout /etc/ceph/iscsi-gateway.key -x509 -days 365 -out /etc/ceph/iscsi-gateway.crt -subj "/C=US/ST=./L=./O=RedHat/OU=Linux/CN={{ ansible_hostname }}"
   run_once: True
 
-- name: (local) create pem
+- name: create pem
   shell: |
     cat /etc/ceph/iscsi-gateway.crt /etc/ceph/iscsi-gateway.key > /etc/ceph/iscsi-gateway.pem
   run_once: True
   register: pem
 
-- name: (local) create public key from pem
+- name: create public key from pem
   shell: |
     openssl x509 -inform pem -in /etc/ceph/iscsi-gateway.pem -pubkey -noout > /etc/ceph/iscsi-gateway-pub.key
   run_once: True

diff --git a/site.yml.sample b/site.yml.sample
index be79b48007f3b7730b3c3b51d1e35e3197d3c7ab..0d6128908d454160441458df62e74ad578d16b35 100644 (file)
--- a/site.yml.sample
+++ b/site.yml.sample
@@ -12,7 +12,7 @@
   - rbdmirrors
   - clients
   - mgrs
-  - iscsi_gws
+  - iscsi-gws
 
   gather_facts: false
 
@@ -142,7 +142,7 @@
     - ceph-config
     - ceph-client
 
-- hosts: iscsi_gws
+- hosts: iscsi-gws
   gather_facts: false
   become: True
   roles:

diff --git a/tests/functional/centos/7/cluster/group_vars/iscsi-gws b/tests/functional/centos/7/cluster/group_vars/iscsi-gws
new file mode 100644 (file)
index 0000000..f08f50a
--- /dev/null
+++ b/tests/functional/centos/7/cluster/group_vars/iscsi-gws
@@ -0,0 +1,2 @@
+---
+gateway_ip_list: 192.168.1.90

diff --git a/tests/functional/centos/7/cluster/hosts b/tests/functional/centos/7/cluster/hosts
index b0bf472bc335cc99a8063431342738957b9cb5a6..257f98aa8a577909d211f4358d57ff948562ae59 100644 (file)
--- a/tests/functional/centos/7/cluster/hosts
+++ b/tests/functional/centos/7/cluster/hosts
@@ -24,5 +24,5 @@ ceph-nfs0
 [rbdmirrors]
 ceph-rbd-mirror0
 
-[iscsi_gws]
+[iscsi-gws]
 ceph-iscsi-gw0 ceph_repository="dev"