Fix branch selection logic

Signed-off-by: Zack Cerza <zack@redhat.com>

diff --git a/teuthology/suite.py b/teuthology/suite.py
index feb143c5450687b972134894eea5bda9d291e44f..214d2a5c9340e6007593357bfc6a979b47321830 100644 (file)
--- a/teuthology/suite.py
+++ b/teuthology/suite.py
@@ -199,7 +199,7 @@ def create_initial_config(suite, suite_branch, ceph_branch, teuthology_branch,
         if not get_branch_info('teuthology', teuthology_branch):
             exc = BranchNotFoundError(teuthology_branch, 'teuthology.git')
             schedule_fail(message=str(exc), name=name)
-    else:
+    elif not teuthology_branch:
         # Decide what branch of teuthology to use
         if get_branch_info('teuthology', ceph_branch):
             teuthology_branch = ceph_branch
@@ -213,7 +213,7 @@ def create_initial_config(suite, suite_branch, ceph_branch, teuthology_branch,
         if not get_branch_info('ceph-qa-suite', suite_branch):
             exc = BranchNotFoundError(suite_branch, 'ceph-qa-suite.git')
             schedule_fail(message=str(exc), name=name)
-    else:
+    elif not suite_branch:
         # Decide what branch of ceph-qa-suite to use
         if get_branch_info('ceph-qa-suite', ceph_branch):
             suite_branch = ceph_branch