]> git-server-git.apps.pok.os.sepia.ceph.com Git - teuthology.git/commitdiff
Fix resolve_role_list in daemon.py 890/head
authorWarren Usui <wusui@redhat.com>
Wed, 29 Jun 2016 02:43:10 +0000 (19:43 -0700)
committerWarren Usui <wusui@redhat.com>
Thu, 30 Jun 2016 22:47:53 +0000 (15:47 -0700)
resolve_role_list did not handle cases where roles specified contained wild-cards or
were not specified.  ceph.role.a would end up being resolved as ceph.rolea.

Fixes: tracker issue 16053
Signed-off-by: Warren Usui <wusui@redhat.com>
teuthology/orchestra/daemon.py

index 690aee07bc8b992566a22286348568a97cb147f0..3c40aaa5d4840512541f059e2ab1f3d98387d6d9 100644 (file)
@@ -238,7 +238,7 @@ class DaemonGroup(object):
                         prefix = type_
                         if cluster_aware:
                             prefix = daemon.role
-                        resolved.append(prefix + daemon.id_)
+                        resolved.append(prefix + '.' + daemon.id_)
         else:
             # Handle explicit list of roles or wildcards
             for raw_role in roles:
@@ -256,7 +256,7 @@ class DaemonGroup(object):
                         prefix = role_type
                         if cluster_aware:
                             prefix = daemon.role
-                        resolved.append(prefix + daemon.id_)
+                        resolved.append(prefix + '.' + daemon.id_)
                 else:
                     # Handle explicit role
                     resolved.append(raw_role)