From: Sage Weil <sage.weil@dreamhost.com>
Date: Wed, 8 Jun 2011 03:48:52 +0000 (-0700)
Subject: mds: open renamed import child frags during journal replay
X-Git-Tag: v0.30~102^2~6
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=00ec86a20412988238320c71b8cf054ca06537d8;p=ceph.git

mds: open renamed import child frags during journal replay

Open up any child frags of the imported renamed inode that are noted in
the journal event.  (Note we blindly open up that list here; it's up to the
journaler to only populate it when appropriate.)  If the listed frags are
not already open, open them up and set the dir_auth to unknown; presumably
they belong to the rename source/exporter.  If we already had them open,
then the adjust_subtree_after_rename call above will have caught them and
already done the necessary subtree adjustment.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
---

diff --git a/src/mds/journal.cc b/src/mds/journal.cc
index bd30592a0bdd9..431c7a391a673 100644
--- a/src/mds/journal.cc
+++ b/src/mds/journal.cc
@@ -574,6 +574,8 @@ void EMetaBlob::replay(MDS *mds, LogSegment *logseg)
       } else {
 	if (dn->get_linkage()->get_inode() != in && in->get_parent_dn()) {
 	  dout(10) << "EMetaBlob.replay unlinking " << *in << dendl;
+	  if (in == renamed_diri)
+	    olddir = dir;
 	  in->get_parent_dn()->get_dir()->unlink_inode(in->get_parent_dn());
 	}
 	if (in->get_parent_dn() && in->inode.anchored != p->inode.anchored)
@@ -605,6 +607,8 @@ void EMetaBlob::replay(MDS *mds, LogSegment *logseg)
       } else {
 	if (!dn->get_linkage()->is_null()) {
 	  dout(10) << "EMetaBlob.replay unlinking " << *dn << dendl;
+	  if (dn->get_linkage()->get_inode() == renamed_diri)
+	    olddir = dir;
 	  dir->unlink_inode(dn);
 	}
 	dir->link_remote_inode(dn, p->ino, p->d_type);
@@ -630,8 +634,7 @@ void EMetaBlob::replay(MDS *mds, LogSegment *logseg)
 	dn->first = p->dnfirst;
 	if (!dn->get_linkage()->is_null()) {
 	  dout(10) << "EMetaBlob.replay unlinking " << *dn << dendl;
-	  if (dn->get_linkage()->is_primary() &&
-	      dn->get_linkage()->get_inode() == renamed_diri)
+	  if (dn->get_linkage()->get_inode() == renamed_diri)
 	    olddir = dir;
 	  dir->unlink_inode(dn);
 	}
@@ -648,11 +651,24 @@ void EMetaBlob::replay(MDS *mds, LogSegment *logseg)
       assert(renamed_diri);
       mds->mdcache->adjust_subtree_after_rename(renamed_diri, olddir, false);
     } else {
-      if (!renamed_diri) {
-	renamed_diri = mds->mdcache->get_inode(renamed_dirino);
-	assert(renamed_diri);
+      // we imported a diri we haven't seen before
+      assert(!renamed_diri);
+      renamed_diri = mds->mdcache->get_inode(renamed_dirino);
+      assert(renamed_diri);  // it was in the metablob
+    }
+
+    // if we are the srci importer, we'll also have some dirfrags we have to open up...
+    for (list<frag_t>::iterator p = renamed_dir_frags.begin(); p != renamed_dir_frags.end(); ++p) {
+      CDir *dir = renamed_diri->get_dirfrag(*p);
+      if (dir) {
+	// we already had the inode before, and we already adjusted this subtree accordingly.
+	dout(10) << " already had+adjusted rename import bound " << *dir << dendl;
+	assert(olddir); 
+	continue;
       }
-      // FIXME.
+      dir = renamed_diri->get_or_open_dirfrag(mds->mdcache, *p);
+      dout(10) << " creating new rename import bound " << *dir << dendl;
+      mds->mdcache->adjust_subtree_auth(dir, pair<int,int>(CDIR_AUTH_UNKNOWN, CDIR_AUTH_UNKNOWN), false);
     }
   }