From: Radosław Zarzyński Date: Tue, 24 Oct 2023 10:25:41 +0000 (+0200) Subject: crimson/osd: PCBackend::_submit_transaction() takes ObjectContext X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=011e77d82667fd42bc394124a79b49d95b7dce42;p=ceph-ci.git crimson/osd: PCBackend::_submit_transaction() takes ObjectContext For the sake of ECBackend. Signed-off-by: Radosław Zarzyński --- diff --git a/src/crimson/osd/ec_backend.cc b/src/crimson/osd/ec_backend.cc index b7afe545220..1b711ec0f2b 100644 --- a/src/crimson/osd/ec_backend.cc +++ b/src/crimson/osd/ec_backend.cc @@ -242,7 +242,7 @@ struct ECCrimsonOp : ECCommon::RMWPipeline::Op { }; ECBackend::rep_op_fut_t ECBackend::submit_transaction(const std::set &pg_shards, - const hobject_t& hoid, + crimson::osd::ObjectContextRef&& obc, crimson::osd::ObjectContextRef&& new_clone, ceph::os::Transaction&& txn, osd_op_params_t&& osd_op_p, diff --git a/src/crimson/osd/ec_backend.h b/src/crimson/osd/ec_backend.h index 36af2451d41..406b2284d20 100644 --- a/src/crimson/osd/ec_backend.h +++ b/src/crimson/osd/ec_backend.h @@ -53,7 +53,7 @@ private: _read(const hobject_t& hoid, uint64_t off, uint64_t len, uint32_t flags) override; rep_op_fut_t submit_transaction(const std::set &pg_shards, - const hobject_t& hoid, + crimson::osd::ObjectContextRef&& obc, crimson::osd::ObjectContextRef&& new_clone, ceph::os::Transaction&& txn, osd_op_params_t&& req, diff --git a/src/crimson/osd/pg.cc b/src/crimson/osd/pg.cc index 6a785a880fc..0d1590096ec 100644 --- a/src/crimson/osd/pg.cc +++ b/src/crimson/osd/pg.cc @@ -987,7 +987,7 @@ PG::submit_transaction( auto [submitted, all_completed] = co_await backend->submit_transaction( peering_state.get_acting_recovery_backfill(), - obc->obs.oi.soid, + std::move(obc), std::move(new_clone), std::move(txn), std::move(osd_op_p), diff --git a/src/crimson/osd/pg_backend.h b/src/crimson/osd/pg_backend.h index 6c1abd0f3b3..3eac0b47253 100644 --- a/src/crimson/osd/pg_backend.h +++ b/src/crimson/osd/pg_backend.h @@ -426,7 +426,7 @@ public: virtual rep_op_fut_t submit_transaction(const std::set &pg_shards, - const hobject_t& hoid, + crimson::osd::ObjectContextRef&& obc, crimson::osd::ObjectContextRef&& new_clone, ceph::os::Transaction&& txn, osd_op_params_t&& osd_op_p, diff --git a/src/crimson/osd/replicated_backend.cc b/src/crimson/osd/replicated_backend.cc index 9fc921294c6..1c8d5e90351 100644 --- a/src/crimson/osd/replicated_backend.cc +++ b/src/crimson/osd/replicated_backend.cc @@ -93,7 +93,7 @@ MURef ReplicatedBackend::new_repop_msg( ReplicatedBackend::rep_op_fut_t ReplicatedBackend::submit_transaction( const std::set &pg_shards, - const hobject_t& hoid, + crimson::osd::ObjectContextRef &&obc, crimson::osd::ObjectContextRef &&new_clone, ceph::os::Transaction&& t, osd_op_params_t&& opp, @@ -101,6 +101,7 @@ ReplicatedBackend::submit_transaction( std::vector&& logv) { LOG_PREFIX(ReplicatedBackend::submit_transaction); + const hobject_t& hoid = obc->obs.oi.soid; DEBUGDPP("object {}", dpp, hoid); auto log_entries = std::move(logv); auto txn = std::move(t); diff --git a/src/crimson/osd/replicated_backend.h b/src/crimson/osd/replicated_backend.h index 88110e5a54b..d1e2cef732f 100644 --- a/src/crimson/osd/replicated_backend.h +++ b/src/crimson/osd/replicated_backend.h @@ -40,7 +40,7 @@ private: uint64_t len, uint32_t flags) override; rep_op_fut_t submit_transaction( const std::set &pg_shards, - const hobject_t& hoid, + crimson::osd::ObjectContextRef&& obc, crimson::osd::ObjectContextRef&& new_clone, ceph::os::Transaction&& txn, osd_op_params_t&& osd_op_p,