From: Sage Weil <sage@redhat.com>
Date: Tue, 17 Dec 2019 13:22:48 +0000 (-0600)
Subject: cephadm: return 'cephadm pull' result as JSON
X-Git-Tag: v15.1.0~171^2~2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=0122679331d414bbf72c32be188b2d62d187f351;p=ceph.git

cephadm: return 'cephadm pull' result as JSON

Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/src/cephadm/cephadm b/src/cephadm/cephadm
index e32b4731f210c..c1faf5103c31c 100755
--- a/src/cephadm/cephadm
+++ b/src/cephadm/cephadm
@@ -1530,7 +1530,10 @@ def command_pull():
         '--format', '{{.Id}}',
         args.image])
     ver = CephContainer(args.image, 'ceph', ['--version']).run()
-    print(out.strip() + ',' + ver)
+    print(json.dumps({
+        'ceph_version': ver,
+        'image_id': out.strip(),
+        }, indent=4, sort_keys=True))
 
 
 ##################################
diff --git a/src/pybind/mgr/cephadm/module.py b/src/pybind/mgr/cephadm/module.py
index ddf88133d3d2c..c6be640aadcbf 100644
--- a/src/pybind/mgr/cephadm/module.py
+++ b/src/pybind/mgr/cephadm/module.py
@@ -1528,7 +1528,9 @@ class CephadmOrchestrator(MgrModule, orchestrator.Orchestrator):
             host, None, 'pull', [],
             image=image_name,
             no_fsid=True)
-        (image_id, ceph_version) = out[0].split(',', 1)
+        j = json.loads('\n'.join(out))
+        image_id = j.get('image_id')
+        ceph_version = j.get('ceph_version')
         self.log.debug('image %s -> id %s version %s' %
                        (image_name, image_id, ceph_version))
         return image_id, ceph_version