From: Kefu Chai <kchai@redhat.com>
Date: Wed, 5 Sep 2018 07:50:47 +0000 (+0800)
Subject: crimson/net: add logging to SocketConnection
X-Git-Tag: v14.0.1~345^2~4
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=029be76e0886c9ab12c54b318baf43fdaca5d201;p=ceph.git

crimson/net: add logging to SocketConnection

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/crimson/net/SocketConnection.cc b/src/crimson/net/SocketConnection.cc
index a3d459ca15a4..3a9cb1f58345 100644
--- a/src/crimson/net/SocketConnection.cc
+++ b/src/crimson/net/SocketConnection.cc
@@ -27,6 +27,8 @@
 #include "auth/AuthSessionHandler.h"
 #include "msg/Message.h"
 
+#include "crimson/common/log.h"
+
 using namespace ceph::net;
 
 template <typename T>
@@ -34,6 +36,12 @@ seastar::net::packet make_static_packet(const T& value) {
     return { reinterpret_cast<const char*>(&value), sizeof(value) };
 }
 
+namespace {
+  seastar::logger& logger() {
+    return ceph::get_logger(ceph_subsys_ms);
+  }
+}
+
 SocketConnection::SocketConnection(Messenger *messenger,
                                    const entity_addr_t& my_addr,
                                    const entity_addr_t& peer_addr,
@@ -663,6 +671,7 @@ seastar::future<> SocketConnection::handle_connect_reply(msgr_tag_t tag)
     return fault();
   case CEPH_MSGR_TAG_BADAUTHORIZER:
     if (h.got_bad_auth) {
+      logger().error("{} got bad authorizer", __func__);
       throw std::system_error(make_error_code(error::negotiation_failure));
     }
     h.got_bad_auth = true;
@@ -724,6 +733,7 @@ seastar::future<> SocketConnection::handle_connect_reply(msgr_tag_t tag)
     return seastar::now();
   } else {
     // unknown tag
+    logger().error("{} got unknown tag", __func__, int(tag));
     throw std::system_error(make_error_code(error::negotiation_failure));
   }
 }
@@ -789,6 +799,7 @@ seastar::future<> SocketConnection::connect(entity_type_t peer_type,
       if (h.authorizer) {
         auto reply = bl.cbegin();
         if (!h.authorizer->verify_reply(reply)) {
+          logger().error("{} authorizer failed to verify reply", __func__);
           throw std::system_error(make_error_code(error::negotiation_failure));
         }
       }