From: Walter  Huf <walter.huf@corvisa.com>
Date: Thu, 27 Mar 2014 17:19:56 +0000 (-0500)
Subject: Boolean functions should end in ?
X-Git-Tag: v0.8.0~50^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=02dde7b534ba59dc22c44e3ef3a977f2212c9a85;p=ceph-cookbooks.git

Boolean functions should end in ?
---

diff --git a/libraries/default.rb b/libraries/default.rb
index 69f0315..47d0101 100644
--- a/libraries/default.rb
+++ b/libraries/default.rb
@@ -34,13 +34,13 @@ def find_node_ip_in_network(network, nodeish = nil)
   nodeish['network']['interfaces'].each do |iface, addrs|
     addresses = addrs['addresses'] || []
     addresses.each do |ip, params|
-      return ip_address_to_ceph_address(ip, params) if ip_address_in_network(ip, params, net)
+      return ip_address_to_ceph_address(ip, params) if ip_address_in_network?(ip, params, net)
     end
   end
   nil
 end
 
-def ip_address_in_network(ip, params, net)
+def ip_address_in_network?(ip, params, net)
   ['inet', 'inet6'].include?(params['family']) && net.include?(ip)
 end