From: Sun Yuechi Date: Thu, 25 Jun 2026 13:39:11 +0000 (+0800) Subject: osd/scheduler: add missing breaks in PGRecoveryMsg::run X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=03cf6f5f00375904d41212f8ec8dce25d1e81b60;p=ceph.git osd/scheduler: add missing breaks in PGRecoveryMsg::run Without these breaks the switch fell through, recording a single message's latency into every following per-type counter. Fixes: https://tracker.ceph.com/issues/77751 Signed-off-by: Sun Yuechi --- diff --git a/src/osd/scheduler/OpSchedulerItem.cc b/src/osd/scheduler/OpSchedulerItem.cc index 7ed99a600980..f1d23c4e728a 100644 --- a/src/osd/scheduler/OpSchedulerItem.cc +++ b/src/osd/scheduler/OpSchedulerItem.cc @@ -214,16 +214,22 @@ void PGRecoveryMsg::run( switch (op->get_req()->get_type()) { case MSG_OSD_PG_PUSH: osd->logger->tinc(l_osd_recovery_push_queue_lat, latency); + break; case MSG_OSD_PG_PUSH_REPLY: osd->logger->tinc(l_osd_recovery_push_reply_queue_lat, latency); + break; case MSG_OSD_PG_PULL: osd->logger->tinc(l_osd_recovery_pull_queue_lat, latency); + break; case MSG_OSD_PG_BACKFILL: osd->logger->tinc(l_osd_recovery_backfill_queue_lat, latency); + break; case MSG_OSD_PG_BACKFILL_REMOVE: osd->logger->tinc(l_osd_recovery_backfill_remove_queue_lat, latency); + break; case MSG_OSD_PG_SCAN: osd->logger->tinc(l_osd_recovery_scan_queue_lat, latency); + break; } osd->dequeue_op(pg, op, handle); pg->unlock();