From: Matty Williams <Matty.Williams@ibm.com>
Date: Thu, 19 Feb 2026 15:07:07 +0000 (+0000)
Subject: cls/test: Make function parameters by reference not by value
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=03ddd5b769b92d2c1202efc42a1abfd3a68b5f05;p=ceph.git

cls/test: Make function parameters by reference not by value

Stops the cls_fifo.get_info test from Segmentation Faulting.

Fixes: https://tracker.ceph.com/issues/74648
Signed-off-by: Matty Williams <Matty.Williams@ibm.com>
---

diff --git a/src/neorados/cls/fifo.h b/src/neorados/cls/fifo.h
index 484dcd44d393..3f15a834bf66 100644
--- a/src/neorados/cls/fifo.h
+++ b/src/neorados/cls/fifo.h
@@ -361,7 +361,7 @@ public:
   template<boost::asio::completion_token_for<
     void(boost::system::error_code, rados::cls::fifo::info,
 	 uint32_t, uint32_t)> CompletionToken>
-  static auto get_meta(neorados::RADOS rados, Object obj, IOContext ioc,
+  static auto get_meta(neorados::RADOS& rados, Object obj, IOContext ioc,
 		       std::optional<rados::cls::fifo::objv> objv,
 		       CompletionToken&& token) {
 
diff --git a/src/test/cls_fifo/ceph_test_neocls_fifo.cc b/src/test/cls_fifo/ceph_test_neocls_fifo.cc
index 7b2020fdf1d0..fd3017007796 100644
--- a/src/test/cls_fifo/ceph_test_neocls_fifo.cc
+++ b/src/test/cls_fifo/ceph_test_neocls_fifo.cc
@@ -46,13 +46,13 @@ namespace fifo = rados::cls::fifo;
 class FIFOtest {
 public:
   template<typename... Args>
-  static auto create_meta(neorados::RADOS rados, Args&&... args) {
+  static auto create_meta(neorados::RADOS& rados, Args&&... args) {
     return detail::FIFOImpl::create_meta(rados,
 					 std::forward<Args>(args)...);
   }
 
   template<typename... Args>
-  static auto get_meta(neorados::RADOS rados, Args&&... args) {
+  static auto get_meta(neorados::RADOS& rados, Args&&... args) {
     return FIFO::get_meta(rados, std::forward<Args>(args)...);
   }