From: Venky Shankar <vshankar@redhat.com>
Date: Tue, 18 Mar 2025 09:01:17 +0000 (+0000)
Subject: Revert "multi-mds/link: Handle rollback for referent_inodes list"
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=03ebed4c0c1e17c6ce9aa475b2efe8b8320f4bb9;p=ceph.git

Revert "multi-mds/link: Handle rollback for referent_inodes list"

This reverts commit c39977ff26f03006aac03ddfb5e285dbe61bd7fe.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
---

diff --git a/src/mds/Server.cc b/src/mds/Server.cc
index f149882ce5df..ac12b672e884 100644
--- a/src/mds/Server.cc
+++ b/src/mds/Server.cc
@@ -8299,7 +8299,6 @@ void Server::handle_peer_link_prep(const MDRequestRef& mdr)
   const auto& pf = targeti->get_parent_dn()->get_dir()->get_projected_fnode();
   rollback.old_dir_mtime = pf->fragstat.mtime;
   rollback.old_dir_rctime = pf->rstat.rctime;
-  rollback.referent_ino = referent_ino;
   rollback.was_inc = inc;
   if (realm_projected) {
     if (targeti->snaprealm) {
@@ -8459,16 +8458,10 @@ void Server::do_link_rollback(bufferlist &rbl, mds_rank_t leader, const MDReques
 
   // inode
   pi.inode->ctime = rollback.old_ctime;
-  if (rollback.was_inc) {
+  if (rollback.was_inc)
     pi.inode->nlink--;
-    if (rollback.referent_ino > 0) {
-      pi.inode->remove_referent_ino(rollback.referent_ino);
-      dout(10) << __func__ << " referent_inodes " << std::hex << pi.inode->get_referent_inodes()
-               << " referent ino removed " << rollback.referent_ino << dendl;
-    }
-  } else {
+  else
     pi.inode->nlink++;
-  }
 
   map<client_t,ref_t<MClientSnap>> splits;
   if (rollback.snapbl.length() && in->snaprealm) {
diff --git a/src/mds/events/EPeerUpdate.h b/src/mds/events/EPeerUpdate.h
index ad999bc0b995..67497c3d6df7 100644
--- a/src/mds/events/EPeerUpdate.h
+++ b/src/mds/events/EPeerUpdate.h
@@ -34,7 +34,6 @@ struct link_rollback {
   utime_t old_dir_mtime;
   utime_t old_dir_rctime;
   bufferlist snapbl;
-  inodeno_t referent_ino;
 
   link_rollback() : ino(0), was_inc(false) {}
 
diff --git a/src/mds/journal.cc b/src/mds/journal.cc
index a7bf55e0fff6..e73796c83c11 100644
--- a/src/mds/journal.cc
+++ b/src/mds/journal.cc
@@ -2606,7 +2606,7 @@ std::list<ECommitted> ECommitted::generate_test_instances()
 
 void link_rollback::encode(bufferlist &bl) const
 {
-  ENCODE_START(4, 2, bl);
+  ENCODE_START(3, 2, bl);
   encode(reqid, bl);
   encode(ino, bl);
   encode(was_inc, bl);
@@ -2614,13 +2614,12 @@ void link_rollback::encode(bufferlist &bl) const
   encode(old_dir_mtime, bl);
   encode(old_dir_rctime, bl);
   encode(snapbl, bl);
-  encode(referent_ino, bl);
   ENCODE_FINISH(bl);
 }
 
 void link_rollback::decode(bufferlist::const_iterator &bl)
 {
-  DECODE_START_LEGACY_COMPAT_LEN(4, 2, 2, bl);
+  DECODE_START_LEGACY_COMPAT_LEN(3, 2, 2, bl);
   decode(reqid, bl);
   decode(ino, bl);
   decode(was_inc, bl);
@@ -2629,8 +2628,6 @@ void link_rollback::decode(bufferlist::const_iterator &bl)
   decode(old_dir_rctime, bl);
   if (struct_v >= 3)
     decode(snapbl, bl);
-  if (struct_v >= 4)
-    decode(referent_ino, bl);
   DECODE_FINISH(bl);
 }
 
@@ -2642,7 +2639,6 @@ void link_rollback::dump(Formatter *f) const
   f->dump_stream("old_ctime") << old_ctime;
   f->dump_stream("old_dir_mtime") << old_dir_mtime;
   f->dump_stream("old_dir_rctime") << old_dir_rctime;
-  f->dump_stream("referent_ino") << referent_ino;
 }
 
 std::list<link_rollback> link_rollback::generate_test_instances()