From: Jianpeng Ma <jianpeng.ma@intel.com>
Date: Fri, 8 Jan 2021 08:11:27 +0000 (+0800)
Subject: msg: using switch-case in place of if-else.
X-Git-Tag: v16.1.0~73^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=0471a2d6c95dd93a4969fdccbde3e4abfa27f933;p=ceph.git

msg: using switch-case in place of if-else.

For point of performance, swith-case is better than if-else for
blackhole check.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
---

diff --git a/src/msg/Connection.cc b/src/msg/Connection.cc
index 21f147b80349..9183871b5942 100644
--- a/src/msg/Connection.cc
+++ b/src/msg/Connection.cc
@@ -7,8 +7,17 @@
 
 bool Connection::is_blackhole() const {
   auto& conf = msgr->cct->_conf;
-  return ((conf->ms_blackhole_mon && peer_type == CEPH_ENTITY_TYPE_MON) ||
-      (conf->ms_blackhole_osd && peer_type == CEPH_ENTITY_TYPE_OSD) ||
-      (conf->ms_blackhole_mds && peer_type == CEPH_ENTITY_TYPE_MDS) ||
-      (conf->ms_blackhole_client && peer_type == CEPH_ENTITY_TYPE_CLIENT));
+
+  switch (peer_type) {
+  case CEPH_ENTITY_TYPE_MON:
+    return conf->ms_blackhole_mon;
+  case CEPH_ENTITY_TYPE_OSD:
+    return conf->ms_blackhole_osd;
+  case CEPH_ENTITY_TYPE_MDS:
+    return conf->ms_blackhole_mds;
+  case CEPH_ENTITY_TYPE_CLIENT:
+    return conf->ms_blackhole_client;
+  default:
+    return false;
+  }
 }