From: Paul Cuzner <pcuzner@redhat.com>
Date: Thu, 18 Feb 2021 23:50:22 +0000 (+1300)
Subject: mgr/cephadm:skip an alert if the linkspeed is better than most
X-Git-Tag: v16.2.0~106^2~78
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=049afe3a1e29cbe9919ffd024c2431c2ad01a9a8;p=ceph.git

mgr/cephadm:skip an alert if the linkspeed is better than most

The logic was issuing a healthcheck if the linkspeed was different
to the majority. But if the difference is good (i.e. better!) we should
not be raising a healthcheck

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
(cherry picked from commit 74a3599a83b5b1dde094721f7754d284e8acf8fa)
---

diff --git a/src/pybind/mgr/cephadm/configchecks.py b/src/pybind/mgr/cephadm/configchecks.py
index 0d855b10000c..36d29c6e723f 100644
--- a/src/pybind/mgr/cephadm/configchecks.py
+++ b/src/pybind/mgr/cephadm/configchecks.py
@@ -511,6 +511,9 @@ class CephadmConfigChecks:
                     speed_copy = subnet_data.speed_map.copy()
                     del speed_copy[speed_ptr]
                     for bad_speed in speed_copy:
+                        if bad_speed > speed_ptr:
+                            # skip speed is better than most...it can stay!
+                            continue
                         for h in speed_copy[bad_speed]:
                             host = HostFacts()
                             host.load_facts(self.mgr.cache.facts[h])