From: Darrick J. Wong Date: Thu, 20 Feb 2025 21:46:57 +0000 (-0800) Subject: dio-writeback-race: fix missing mode in O_CREAT X-Git-Tag: v2025.03.09~74 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=04b1fc9de8858c18d772828ba731bb6e4057a04c;p=xfstests-dev.git dio-writeback-race: fix missing mode in O_CREAT Fix this build error: In file included from /usr/include/fcntl.h:314, from dio-writeback-race.c:40: In function 'open', inlined from 'main' at dio-writeback-race.c:110:7: /usr/include/x86_64-linux-gnu/bits/fcntl2.h:50:11: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT or O_TMPFILE in second argument needs 3 arguments 50 | __open_missing_mode (); | ^~~~~~~~~~~~~~~~~~~~~~ Cc: # v2025.02.16 Fixes: 17fb49493426ad ("fstests: add a generic test to verify direct IO writes with buffer contents change") Signed-off-by: "Darrick J. Wong" Reviewed-by: Christoph Hellwig Signed-off-by: Zorro Lang --- diff --git a/src/dio-writeback-race.c b/src/dio-writeback-race.c index 963ed207..2d3156e5 100644 --- a/src/dio-writeback-race.c +++ b/src/dio-writeback-race.c @@ -107,7 +107,7 @@ int main (int argc, char *argv[]) fprintf(stderr, "failed to allocate aligned memory\n"); exit(EXIT_FAILURE); } - fd = open(argv[optind], O_DIRECT | O_WRONLY | O_CREAT); + fd = open(argv[optind], O_DIRECT | O_WRONLY | O_CREAT, 0600); if (fd < 0) { fprintf(stderr, "failed to open file '%s': %m\n", argv[optind]); goto error;