From: Mark Callaghan <mcallaghan@fb.com>
Date: Mon, 13 Jun 2022 23:24:32 +0000 (-0700)
Subject: Increase num_levels for universal from 8 to 40 (#10158)
X-Git-Tag: v7.4.3~42
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=04bd3479956bb72f37831999649c3855eb976ff1;p=rocksdb.git

Increase num_levels for universal from 8 to 40 (#10158)

Summary:
See https://github.com/facebook/rocksdb/issues/10082 for more details. Trivial move
isn't done for universal when compaction is from L0 into L0. So a too small value for
num_levels with db_bench means there will be fewer trivial moves with universal and
that means that write-amp will increase.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/10158

Test Plan: run it

Reviewed By: siying

Differential Revision: D37122519

Pulled By: mdcallag

fbshipit-source-id: 1cb39049676f68a6cc3ea8d105a9965f89d4d09e
---

diff --git a/tools/benchmark.sh b/tools/benchmark.sh
index 877712935..07d3144d8 100755
--- a/tools/benchmark.sh
+++ b/tools/benchmark.sh
@@ -233,7 +233,6 @@ const_params_base="
   --wal_dir=$WAL_DIR \
   \
   --num=$num_keys \
-  --num_levels=8 \
   --key_size=$key_size \
   --value_size=$value_size \
   --block_size=$block_size \
@@ -271,6 +270,7 @@ const_params_base="
 level_const_params="
   $const_params_base \
   --compaction_style=0 \
+  --num_levels=8 \
   --min_level_to_compress=$min_level_to_compress \
   --level_compaction_dynamic_level_bytes=true \
   --pin_l0_filter_and_index_blocks_in_cache=1 \
@@ -295,6 +295,7 @@ blob_const_params="
 univ_const_params="
   $const_params_base \
   --compaction_style=1 \
+  --num_levels=40 \
   --universal_compression_size_percent=$compression_size_percent \
   --pin_l0_filter_and_index_blocks_in_cache=1 \
   --universal_min_merge_width=$univ_min_merge_width \