From: Sebastian Wagner Date: Sat, 6 Jun 2020 22:53:34 +0000 (+0200) Subject: mgr/cephadm: Add an event when creating a service X-Git-Tag: wip-pdonnell-testing-20200918.022351~636^2~2 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=05ade49a0900ae0714a8bfe53a8b993d46d5be50;p=ceph-ci.git mgr/cephadm: Add an event when creating a service Signed-off-by: Sebastian Wagner --- diff --git a/src/pybind/mgr/cephadm/inventory.py b/src/pybind/mgr/cephadm/inventory.py index 616a303e5f6..1f059186b32 100644 --- a/src/pybind/mgr/cephadm/inventory.py +++ b/src/pybind/mgr/cephadm/inventory.py @@ -136,6 +136,7 @@ class SpecStore(): 'created': self.spec_created[spec.service_name()].strftime(DATEFMT), }, sort_keys=True), ) + self.mgr.events.for_service(spec, OrchestratorEvent.INFO, 'service was created') def rm(self, service_name): # type: (str) -> bool diff --git a/src/pybind/mgr/cephadm/module.py b/src/pybind/mgr/cephadm/module.py index 3d96eede9fb..e679947d1bb 100644 --- a/src/pybind/mgr/cephadm/module.py +++ b/src/pybind/mgr/cephadm/module.py @@ -1384,6 +1384,7 @@ you may want to run: container_image_id=dd.container_image_id, container_image_name=dd.container_image_name, spec=spec, + events=self.events.get_for_service(spec.service_name()), ) if n in self.spec_store.specs: if dd.daemon_type == 'osd': @@ -1422,6 +1423,7 @@ you may want to run: spec=spec, size=spec.placement.get_host_selection_size(self.inventory.all_specs()), running=0, + events=self.events.get_for_service(spec.service_name()), ) if service_type == 'nfs': spec = cast(NFSServiceSpec, spec) diff --git a/src/pybind/mgr/cephadm/tests/test_cephadm.py b/src/pybind/mgr/cephadm/tests/test_cephadm.py index 1d746fcd4a4..aaa2a86fedf 100644 --- a/src/pybind/mgr/cephadm/tests/test_cephadm.py +++ b/src/pybind/mgr/cephadm/tests/test_cephadm.py @@ -133,9 +133,12 @@ class TestCephadm(object): 'service_id': 'r.z', 'service_name': 'rgw.r.z', 'service_type': 'rgw', - 'status': {'running': 0, 'size': 1} + 'status': {'running': 0, 'size': 1}, } ] + for o in out: + if 'events' in o: + del o['events'] # delete it, as it contains a timestamp assert out == expected assert [ServiceDescription.from_json(o).to_json() for o in expected] == expected