From: Samuel Just <sjust@redhat.com>
Date: Fri, 30 Sep 2022 05:32:03 +0000 (-0700)
Subject: crimson/common/operation: record op holding OrderedExclusivePhase, add dump_detail
X-Git-Tag: v18.1.0~1068^2~7
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=05caa22b843fd976055afa5b79f9d96907e6d4c7;p=ceph.git

crimson/common/operation: record op holding OrderedExclusivePhase, add dump_detail

Signed-off-by: Samuel Just <sjust@redhat.com>
---

diff --git a/src/crimson/common/operation.cc b/src/crimson/common/operation.cc
index 4532ab7cec7e..53399fb9b842 100644
--- a/src/crimson/common/operation.cc
+++ b/src/crimson/common/operation.cc
@@ -2,7 +2,6 @@
 // vim: ts=8 sw=2 smarttab
 
 #include "operation.h"
-#include "common/Formatter.h"
 
 namespace crimson {
 
diff --git a/src/crimson/common/operation.h b/src/crimson/common/operation.h
index 73ee6919c9ae..61ad05887f42 100644
--- a/src/crimson/common/operation.h
+++ b/src/crimson/common/operation.h
@@ -19,6 +19,7 @@
 #include "include/ceph_assert.h"
 #include "include/utime.h"
 #include "common/Clock.h"
+#include "common/Formatter.h"
 #include "crimson/common/interruptible_future.h"
 #include "crimson/common/smp_helpers.h"
 #include "crimson/common/log.h"
@@ -206,6 +207,8 @@ public:
 	return std::forward<FutureT>(fut);
       }
 
+      const OpT &get_op() { return op; }
+
     protected:
       void record_blocking(const T& blocker) override {
 	this->event.trigger(op, blocker);
@@ -312,6 +315,7 @@ class Operation : public boost::intrusive_ref_counter<
   Operation, boost::thread_unsafe_counter> {
  public:
   using id_t = uint64_t;
+  static constexpr id_t NULL_ID = std::numeric_limits<uint64_t>::max();
   id_t get_id() const {
     return id;
   }
@@ -552,12 +556,19 @@ public:
  */
 template <class T>
 class OrderedExclusivePhaseT : public PipelineStageIT<T> {
-  void dump_detail(ceph::Formatter *f) const final {}
+  void dump_detail(ceph::Formatter *f) const final {
+    f->dump_unsigned("waiting", waiting);
+    if (held_by != Operation::NULL_ID) {
+      f->dump_unsigned("held_by_operation_id", held_by);
+    }
+  }
 
   class ExitBarrier final : public PipelineExitBarrierI {
     OrderedExclusivePhaseT *phase;
+    Operation::id_t op_id;
   public:
-    ExitBarrier(OrderedExclusivePhaseT *phase) : phase(phase) {}
+    ExitBarrier(OrderedExclusivePhaseT *phase, Operation::id_t id)
+      : phase(phase), op_id(id) {}
 
     seastar::future<> wait() final {
       return seastar::now();
@@ -566,11 +577,12 @@ class OrderedExclusivePhaseT : public PipelineStageIT<T> {
     void exit() final {
       if (phase) {
 	auto *p = phase;
+	auto id = op_id;
 	phase = nullptr;
 	std::ignore = seastar::smp::submit_to(
 	  p->get_core(),
-	  [p] {
-	    p->exit();
+	  [p, id] {
+	    p->exit(id);
 	  });
       }
     }
@@ -584,20 +596,37 @@ class OrderedExclusivePhaseT : public PipelineStageIT<T> {
     }
   };
 
-  void exit() {
+  void exit(Operation::id_t op_id) {
+    clear_held_by(op_id);
     mutex.unlock();
   }
 
 public:
-  template <class... IgnoreArgs>
-  seastar::future<PipelineExitBarrierI::Ref> enter(IgnoreArgs&&...) {
-    return mutex.lock().then([this] {
-      return PipelineExitBarrierI::Ref(new ExitBarrier{this});
+  template <class TriggerT>
+  seastar::future<PipelineExitBarrierI::Ref> enter(TriggerT& t) {
+    waiting++;
+    return mutex.lock().then([this, op_id=t.get_op().get_id()] {
+      ceph_assert_always(waiting > 0);
+      --waiting;
+      set_held_by(op_id);
+      return PipelineExitBarrierI::Ref(new ExitBarrier{this, op_id});
     });
   }
 
 private:
+  void set_held_by(Operation::id_t id) {
+    ceph_assert_always(held_by == Operation::NULL_ID);
+    held_by = id;
+  }
+
+  void clear_held_by(Operation::id_t id) {
+    ceph_assert_always(held_by == id);
+    held_by = Operation::NULL_ID;
+  }
+
+  unsigned waiting = 0;
   seastar::shared_mutex mutex;
+  Operation::id_t held_by = Operation::NULL_ID;
 };
 
 /**