From: Michael Fritch <mfritch@suse.com>
Date: Wed, 26 May 2021 10:29:00 +0000 (-0600)
Subject: cephadm: clean-up imports
X-Git-Tag: v16.2.5~72^2~11
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=062871b7082ed7ac805e73522deba9e58b2c2aeb;p=ceph.git

cephadm: clean-up imports

Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit 8fb0a5019c8ba7bf031eed7020bce10afff988e1)
---

diff --git a/src/cephadm/tests/fixtures.py b/src/cephadm/tests/fixtures.py
index a3f46253976e..bd0ae193a148 100644
--- a/src/cephadm/tests/fixtures.py
+++ b/src/cephadm/tests/fixtures.py
@@ -1,12 +1,10 @@
-
 import mock
-from mock import patch
-import pytest
-
 import os
+import pytest
 import time
 
-with patch('builtins.open', create=True):
+
+with mock.patch('builtins.open', create=True):
     from importlib.machinery import SourceFileLoader
     cd = SourceFileLoader('cephadm', 'cephadm').load_module()
 
diff --git a/src/cephadm/tests/test_cephadm.py b/src/cephadm/tests/test_cephadm.py
index ec804c2ff423..95c335de1d64 100644
--- a/src/cephadm/tests/test_cephadm.py
+++ b/src/cephadm/tests/test_cephadm.py
@@ -1,26 +1,28 @@
 # type: ignore
-from typing import List, Optional
+
+import errno
 import mock
-from mock import patch, call
 import os
+import pytest
+import socket
 import sys
-import unittest
-import threading
 import time
-import errno
-import socket
+import threading
+import unittest
+
 from http.server import HTTPServer
 from urllib.request import Request, urlopen
 from urllib.error import HTTPError
 
-import pytest
-
+from typing import List, Optional
 from .fixtures import exporter
 
-with patch('builtins.open', create=True):
+
+with mock.patch('builtins.open', create=True):
     from importlib.machinery import SourceFileLoader
     cd = SourceFileLoader('cephadm', 'cephadm').load_module()
 
+
 class TestCephAdm(object):
 
     @staticmethod
@@ -107,7 +109,7 @@ class TestCephAdm(object):
             except:
                 assert False
             else:
-                assert _socket.call_args == call(address_family, socket.SOCK_STREAM)
+                assert _socket.call_args == mock.call(address_family, socket.SOCK_STREAM)
 
     @mock.patch('socket.socket')
     @mock.patch('cephadm.logger')
@@ -999,10 +1001,10 @@ class TestMonitoring(object):
             daemon_id=daemon_id
         )
         assert _open.call_args_list == [
-            call('{}/etc/prometheus/prometheus.yml'.format(prefix), 'w',
+            mock.call('{}/etc/prometheus/prometheus.yml'.format(prefix), 'w',
                  encoding='utf-8'),
-            call('{}/etc/prometheus/alerting/ceph_alerts.yml'.format(prefix), 'w',
+            mock.call('{}/etc/prometheus/alerting/ceph_alerts.yml'.format(prefix), 'w',
                  encoding='utf-8'),
         ]
-        assert call().__enter__().write('foo') in _open.mock_calls
-        assert call().__enter__().write('bar') in _open.mock_calls
+        assert mock.call().__enter__().write('foo') in _open.mock_calls
+        assert mock.call().__enter__().write('bar') in _open.mock_calls