From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Fri, 10 May 2013 11:28:32 +0000 (+0200)
Subject: test/omap_bench.cc: remove dead code
X-Git-Tag: v0.63~41^2~15
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=077cdb048762bccd252c7ed3e03d7121c96298d9;p=ceph.git

test/omap_bench.cc: remove dead code

CID 716900 Logically dead code (CWE-561)
CID 716901 Logically dead code (CWE-561)
CID 727968 Logically dead code (CWE-561)

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/test/omap_bench.cc b/src/test/omap_bench.cc
index f00908acd48b..4cb15a1b5cd2 100644
--- a/src/test/omap_bench.cc
+++ b/src/test/omap_bench.cc
@@ -315,7 +315,6 @@ int OmapBench::write_omap_asynchronously(AioWriter *aiow,
 int OmapBench::generate_uniform_omap(const int omap_entries, const int key_size,
     const int value_size, std::map<std::string,bufferlist> * out_omap) {
   bufferlist bl;
-  int err = 0;
 
   //setup omap
   for (int i = 0; i < omap_entries; i++) {
@@ -324,18 +323,13 @@ int OmapBench::generate_uniform_omap(const int omap_entries, const int key_size,
     string key = random_string(key_size);
     (*out_omap)[key]= omap_val;
   }
-  if (err < 0) {
-    cout << "generating uniform omap failed - "
-	<< "appending random string to omap failed" << std::endl;
-  }
-  return err;
+  return 0;
 }
 
 int OmapBench::generate_non_uniform_omap(const int omap_entries,
     const int key_size, const int value_size,
     std::map<std::string,bufferlist> * out_omap) {
   bufferlist bl;
-  int err = 0;
 
   int num_entries = rand() % omap_entries + 1;
   int key_len = rand() % key_size +1;
@@ -348,11 +342,7 @@ int OmapBench::generate_non_uniform_omap(const int omap_entries,
     string key = random_string(key_len);
     (*out_omap)[key] = omap_val;
   }
-  if (err < 0) {
-    cout << "generating non-uniform omap failed - "
-	"appending random string to omap failed" << std::endl;
-  }
-  return err;
+  return 0;
 }
 
 int OmapBench::generate_small_non_random_omap(const int omap_entries,
@@ -360,7 +350,6 @@ int OmapBench::generate_small_non_random_omap(const int omap_entries,
     std::map<std::string,bufferlist> * out_omap) {
   bufferlist bl;
   stringstream key;
-  int err = 0;
 
   //setup omap
   for (int i = 0; i < omap_entries; i++) {
@@ -370,11 +359,7 @@ int OmapBench::generate_small_non_random_omap(const int omap_entries,
     key << "Key " << i;
     (*out_omap)[key.str()]= omap_val;
   }
-  if (err < 0) {
-    cout << "generating uniform omap failed - "
-	<< "appending random string to omap failed" << std::endl;
-  }
-  return err;
+  return 0;
 }
 
 //tests