From: xiexingguo <xie.xingguo@zte.com.cn>
Date: Fri, 26 Feb 2016 11:35:55 +0000 (+0800)
Subject: osd: update sprintf() to snprintf()
X-Git-Tag: v10.1.0~248^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=083a0064a359ccca6f08fa9a9dc134d607244cae;p=ceph.git

osd: update sprintf() to snprintf()

Which is safer. Also enlarge length of name to 32, which shall be
big enough to hold a int64_t value.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
---

diff --git a/src/osd/OSDMap.cc b/src/osd/OSDMap.cc
index 9a01c1b21977..855d33075e92 100644
--- a/src/osd/OSDMap.cc
+++ b/src/osd/OSDMap.cc
@@ -2771,8 +2771,8 @@ int OSDMap::build_simple_crush_map(CephContext *cct, CrushWrapper& crush,
     loc["rack"] = "localrack";
     loc["root"] = "default";
     ldout(cct, 10) << " adding osd." << o << " at " << loc << dendl;
-    char name[8];
-    sprintf(name, "osd.%d", o);
+    char name[32];
+    snprintf(name, sizeof(name), "osd.%d", o);
     crush.insert_item(cct, o, 1.0, name, loc);
   }