From: Igor Fedotov <ifedotov@suse.com>
Date: Fri, 25 Jan 2019 17:40:16 +0000 (+0300)
Subject: os/bluestore: option to disable bluestore warns on spillover.
X-Git-Tag: v14.1.0~227^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=086863832c8b6f477de65e38a1fdd249f39b4140;p=ceph-ci.git

os/bluestore: option to disable bluestore warns on spillover.

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
---

diff --git a/src/common/legacy_config_opts.h b/src/common/legacy_config_opts.h
index a8fd2ac4eaf..56cb8d6e5ea 100644
--- a/src/common/legacy_config_opts.h
+++ b/src/common/legacy_config_opts.h
@@ -1075,6 +1075,7 @@ OPTION(bluestore_debug_random_read_err, OPT_DOUBLE)
 OPTION(bluestore_debug_inject_bug21040, OPT_BOOL)
 OPTION(bluestore_debug_inject_csum_err_probability, OPT_FLOAT)
 OPTION(bluestore_no_per_pool_stats_tolerance, OPT_STR)
+OPTION(bluestore_warn_on_bluefs_spillover, OPT_BOOL)
 
 OPTION(kstore_max_ops, OPT_U64)
 OPTION(kstore_max_bytes, OPT_U64)
diff --git a/src/common/options.cc b/src/common/options.cc
index 71bb8ff1c6b..f81c5007a6b 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -4600,6 +4600,10 @@ std::vector<Option> get_global_options() {
       "'until_fsck' will tolerate the case for regular ops and fail on fsck or repair, the latter will fix the issue, "
       "'until_repair' will tolerate for regular ops and fsck. Repair indicates and fixes the issue, "
       "'enforce' will unconditionally use global stats mode."),
+
+    Option("bluestore_warn_on_bluefs_spillover", Option::TYPE_BOOL, Option::LEVEL_ADVANCED)
+    .set_default(true)
+    .set_description("Enable health indication on bluefs slow device usage"),
     // -----------------------------------------
     // kstore
 
diff --git a/src/os/bluestore/BlueStore.cc b/src/os/bluestore/BlueStore.cc
index 06f9544c919..b62fb520588 100644
--- a/src/os/bluestore/BlueStore.cc
+++ b/src/os/bluestore/BlueStore.cc
@@ -13612,7 +13612,8 @@ void BlueStore::_log_alerts(osd_alert_list_t& alerts)
 {
   std::lock_guard l(qlock);
 
-  if (!spillover_alert.empty()) {
+  if (!spillover_alert.empty() &&
+      cct->_conf->bluestore_warn_on_bluefs_spillover) {
     alerts.emplace(
       "BLUEFS_SPILLOVER",
       spillover_alert);