From: Afreen Misbah <afreen@ibm.com>
Date: Thu, 9 Oct 2025 12:27:21 +0000 (+0530)
Subject: mgr/dashboard: Remove unused css
X-Git-Tag: testing/wip-vshankar-testing-20251027.053005-debug~125^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=088e746173f408fec3cd82bfd8ba6a5ba8c8c337;p=ceph-ci.git

mgr/dashboard: Remove unused css

Signed-off-by: Afreen Misbah <afreen@ibm.com>
---

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-area/notification-area.component.html b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-area/notification-area.component.html
index 8dd5a48e7d7..e9814713b45 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-area/notification-area.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-area/notification-area.component.html
@@ -3,10 +3,9 @@
              let-last="last">
   <div class="notification-wrapper">
     <div class="notification-item">
-      <div class="notification-icon">
-        <cd-icon [type]="notificationIconMap[notification.type] || notificationIconMap['default']">
-        </cd-icon>
-      </div>
+      <cd-icon id="notification-icon"
+               [type]="notificationIconMap[notification.type] || notificationIconMap['default']">
+      </cd-icon>
       <div class="notification-content">
         <div class="notification-timestamp">{{ notification.timestamp | relativeDate }}</div>
         <div class="notification-title">{{ notification.title }}</div>
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-area/notification-area.component.scss b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-area/notification-area.component.scss
index 14bf38ff9db..c7ddebbd465 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-area/notification-area.component.scss
+++ b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-area/notification-area.component.scss
@@ -43,21 +43,6 @@
   display: block;
 }
 
-.notification-icon {
-  flex-shrink: 0;
-  margin-top: 0;
-  width: 20px;
-  height: 20px;
-  display: flex;
-  align-items: center;
-  justify-content: center;
-
-  svg {
-    width: 16px;
-    height: 16px;
-  }
-}
-
 .notification-empty {
   margin: 0;
   padding: $spacing-05;
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-area/notification-area.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-area/notification-area.component.spec.ts
index 7fb06f5ce7c..095524df5af 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-area/notification-area.component.spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-area/notification-area.component.spec.ts
@@ -107,7 +107,7 @@ describe('NotificationAreaComponent', () => {
       firstNotification.query(By.css('.notification-message')).nativeElement.textContent
     ).toContain('message');
 
-    const iconElement = firstNotification.query(By.css('.notification-icon cd-icon'));
+    const iconElement = firstNotification.query(By.css('#notification-icon'));
     expect(iconElement).toBeTruthy();
   });
 
@@ -119,12 +119,12 @@ describe('NotificationAreaComponent', () => {
   });
 
   it('should render notification icons with correct types', () => {
-    const iconElements = fixture.debugElement.queryAll(By.css('.notification-icon cd-icon'));
+    const iconElements = fixture.debugElement.queryAll(By.css('#notification-icon'));
     expect(iconElements.length).toBe(2);
 
     // Check that icons have the correct type attribute
     expect(iconElements[0].attributes['ng-reflect-type']).toBe('success');
-    expect(iconElements[1].attributes['ng-reflect-type']).toBe('danger');
+    expect(iconElements[1].attributes['ng-reflect-type']).toBe('error');
   });
 
   it('should render notification dividers between items', () => {
@@ -170,8 +170,8 @@ describe('NotificationAreaComponent', () => {
 
   it('should handle notification icon mapping correctly', () => {
     expect(component.notificationIconMap[NotificationType.success]).toBe('success');
-    expect(component.notificationIconMap[NotificationType.error]).toBe('danger');
-    expect(component.notificationIconMap[NotificationType.info]).toBe('info');
+    expect(component.notificationIconMap[NotificationType.error]).toBe('error');
+    expect(component.notificationIconMap[NotificationType.info]).toBe('infoCircle');
     expect(component.notificationIconMap[NotificationType.warning]).toBe('warning');
   });
 
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/components/icon/icon.component.html b/src/pybind/mgr/dashboard/frontend/src/app/shared/components/icon/icon.component.html
index f1182dd46d0..2f176abf74c 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/shared/components/icon/icon.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/components/icon/icon.component.html
@@ -1,3 +1,4 @@
 <svg  [cdsIcon]="icon"
       [size]="size"
-      [class]="type+'-icon'"></svg>
+      [class]="type+'-icon'"
+      id="icon"></svg>