From: Patrick Donnelly <pdonnell@redhat.com>
Date: Thu, 3 Jan 2019 22:02:52 +0000 (-0800)
Subject: mds: do not log internal journal error
X-Git-Tag: v14.1.0~287^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=0992ac1fa62edb6143efc80a6fea7b4704107705;p=ceph-ci.git

mds: do not log internal journal error

MDS can't reach this code due to assert in C_MDS_session_finish.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
---

diff --git a/src/mds/Server.cc b/src/mds/Server.cc
index dff5853f038..00d291e9071 100644
--- a/src/mds/Server.cc
+++ b/src/mds/Server.cc
@@ -589,14 +589,8 @@ void Server::handle_client_session(const MClientSession::const_ref &m)
       sseq = mds->sessionmap.set_state(session, Session::STATE_OPENING);
       mds->sessionmap.touch_session(session);
       auto fin = new FunctionContext([log_session_status = std::move(log_session_status)](int r){
-        if (r == 0) {
-          log_session_status("ACCEPTED", "");
-        } else {
-          CachedStackStringStream _ss;
-          auto& ss = _ss.get_stream();
-          ss << "(internal) r = " << r;
-          log_session_status("REJECTED", ss.strv());
-        }
+        ceph_assert(r == 0);
+        log_session_status("ACCEPTED", "");
       });
       mdlog->start_submit_entry(new ESession(m->get_source_inst(), true, pv, client_metadata),
 				new C_MDS_session_finish(this, session, sseq, true, pv, fin));