From: Vallari Agrawal <vallari.agrawal@ibm.com>
Date: Thu, 3 Jul 2025 13:25:45 +0000 (+0530)
Subject: qa: allow overrides for nvmeof task
X-Git-Tag: v21.0.0~231^2~19^2~4
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=09c90340c1c8f38ab25338d310df85cf14017759;p=ceph.git

qa: allow overrides for nvmeof task

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
---

diff --git a/qa/tasks/nvmeof.py b/qa/tasks/nvmeof.py
index 591f1b60db88..d5f345bbfa2f 100644
--- a/qa/tasks/nvmeof.py
+++ b/qa/tasks/nvmeof.py
@@ -22,7 +22,7 @@ gw_yaml_file = '/etc/ceph/nvmeof-gw.yaml'
 class Nvmeof(Task):
     """
     Setup nvmeof gateway on client and then share gateway config to target host.
-
+    tasks:
         - nvmeof:
             installer: host.a     // or 'nvmeof.nvmeof.a' 
             version: default
@@ -33,6 +33,16 @@ class Nvmeof(Task):
                 namespaces_count: 10
                 cli_version: latest
                 create_mtls_secrets: False 
+
+    You can pass extra conf file to override above setup values:
+
+    overrides: 
+        nvmeof:
+            gw_image: quay.io/ceph/nvmeof:devel
+            gateway_config:
+                subsystems_count: 3
+                namespaces_count: 20
+                cli_image: quay.io/ceph/nvmeof-cli:devel
                     
     """
 
@@ -44,6 +54,8 @@ class Nvmeof(Task):
             raise ConfigError('nvmeof requires a installer host to deploy service') 
         self.cluster_name, _, _ = misc.split_role(host)
         self.remote = get_remote_for_role(self.ctx, host)  
+        overrides = self.ctx.config.get('overrides', {})
+        misc.deep_merge(self.config, overrides.get('nvmeof', {}))
 
     def begin(self):
         super(Nvmeof, self).begin()