From: Sridhar Seshasayee <sseshasa@redhat.com>
Date: Tue, 22 Feb 2022 12:25:44 +0000 (+0530)
Subject: osd: Write non-zero data as part of osd benchmark test.
X-Git-Tag: v18.0.0~1341^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=09f94ace863255a7dd7075e269f8d7d63a398495;p=ceph.git

osd: Write non-zero data as part of osd benchmark test.

An optimization (see PR: https://github.com/ceph/ceph/pull/43337) was made
in BlueStore to avoid writing bufferlists made up of zeros. The osd
benchmark used zero filled bufferlists and this resulted in inflated osd
benchmark results.

This issue is fixed by using bufferlists filled with non-zero values.

Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
Fixes: https://tracker.ceph.com/issues/54364
---

diff --git a/src/osd/OSD.cc b/src/osd/OSD.cc
index 3b0fc860b91b..b7a68225e060 100644
--- a/src/osd/OSD.cc
+++ b/src/osd/OSD.cc
@@ -3226,7 +3226,7 @@ int OSD::run_osd_bench_test(
   if (osize && onum) {
     bufferlist bl;
     bufferptr bp(osize);
-    bp.zero();
+    memset(bp.c_str(), 'a', bp.length());
     bl.push_back(std::move(bp));
     bl.rebuild_page_aligned();
     for (int i=0; i<onum; ++i) {
@@ -3243,7 +3243,7 @@ int OSD::run_osd_bench_test(
 
   bufferlist bl;
   bufferptr bp(bsize);
-  bp.zero();
+  memset(bp.c_str(), 'a', bp.length());
   bl.push_back(std::move(bp));
   bl.rebuild_page_aligned();