From: Ronen Friedman <rfriedma@redhat.com>
Date: Thu, 15 Feb 2024 18:11:22 +0000 (-0600)
Subject: osd: clean compiler warnings
X-Git-Tag: v19.1.0~283^2~1
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=0a031e5f4e90bc96d91bc5d57cd03e2f51aae688;p=ceph.git

osd: clean compiler warnings

... for unused variables, for code that has no effect, and
for trying to std::move out of a const lvalue.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
---

diff --git a/src/osd/PrimaryLogPG.cc b/src/osd/PrimaryLogPG.cc
index ca83a563e4f8d..6e6e081444e55 100644
--- a/src/osd/PrimaryLogPG.cc
+++ b/src/osd/PrimaryLogPG.cc
@@ -11531,7 +11531,7 @@ void PrimaryLogPG::submit_log_entries(
   }
 
   pgbackend->call_write_ordered(
-    [this, entries, repop, on_complete]() {
+    [this, entries, repop, on_complete]() mutable {
       ObjectStore::Transaction t;
       eversion_t old_last_update = info.last_update;
       recovery_state.merge_new_log_entries(
@@ -12109,7 +12109,6 @@ int PrimaryLogPG::find_object_context(const hobject_t& oid,
   dout(20) << __func__ << " " << soid
 	   << " snapset " << obc->ssc->snapset
 	   << dendl;
-  snapid_t first, last;
   auto p = obc->ssc->snapset.clone_snaps.find(soid.snap);
   ceph_assert(p != obc->ssc->snapset.clone_snaps.end());
   if (p->second.empty()) {
diff --git a/src/test/crush/crush.cc b/src/test/crush/crush.cc
index 2be7d5540d8dc..c9f670a9e322a 100644
--- a/src/test/crush/crush.cc
+++ b/src/test/crush/crush.cc
@@ -337,11 +337,6 @@ TEST_P(IndepTest, out_progressive) {
       if (i > 0) cout << "marked out " << i - 1 << " ";
       cout << x << " -> " << out << std::endl;
 
-      int num_none = 0;
-      for (unsigned k=0; k<out.size(); ++k) {
-	if (out[k] == CRUSH_ITEM_NONE)
-	  num_none++;
-      }
       ASSERT_EQ(0, get_num_dups(out));
 
       // make sure nothing moved