From: Avan Thakkar <athakkar@redhat.com>
Date: Tue, 20 Sep 2022 20:30:31 +0000 (+0530)
Subject: exporter: avoid stoi for empty pid_str
X-Git-Tag: v17.2.6~488^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=0a83b88f5a4c65534f151bdf2e98dd3f9240c935;p=ceph.git

exporter: avoid stoi for empty pid_str

Fixes: https://tracker.ceph.com/issues/57619
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit cff3cf1d31342be759cdd848cd074a247b56b238)
---

diff --git a/src/exporter/DaemonMetricCollector.cc b/src/exporter/DaemonMetricCollector.cc
index 7f88113b9905..6eb11b1225cf 100644
--- a/src/exporter/DaemonMetricCollector.cc
+++ b/src/exporter/DaemonMetricCollector.cc
@@ -114,7 +114,9 @@ void DaemonMetricCollector::dump_asok_metrics() {
     if (!pid_path.size()) {
       continue;
     }
-    daemon_pids.push_back({daemon_name, std::stoi(pid_str)});
+    if (!pid_str.empty()) {
+      daemon_pids.push_back({daemon_name, std::stoi(pid_str)});
+    }
     json_object dump = boost::json::parse(perf_dump_response).as_object();
     json_object schema = boost::json::parse(perf_schema_response).as_object();
     for (auto &perf : schema) {