From: Ken Dreyer Date: Fri, 21 Apr 2023 14:48:14 +0000 (-0400) Subject: use spaces around variables for ansible-lint X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=0c60b3ddd8df459b738686ccd5123eeff7c571e6;p=ceph-cm-ansible.git use spaces around variables for ansible-lint --- diff --git a/roles/cobbler/tasks/settings.yml b/roles/cobbler/tasks/settings.yml index 8623bc2..971e55f 100644 --- a/roles/cobbler/tasks/settings.yml +++ b/roles/cobbler/tasks/settings.yml @@ -28,5 +28,5 @@ when: users_digest is changed or dynamic_settings is changed or server_value is changed - name: Update settings - command: cobbler setting edit --name={{ item.name }} --value={{ item.value}} + command: cobbler setting edit --name={{ item.name }} --value={{ item.value }} with_items: "{{ settings }}" diff --git a/roles/fog-server/tasks/main.yml b/roles/fog-server/tasks/main.yml index a647a31..17c4de1 100644 --- a/roles/fog-server/tasks/main.yml +++ b/roles/fog-server/tasks/main.yml @@ -9,7 +9,7 @@ - name: Ensure a path for FOG file: - path: "/home/{{ fog_user}}/fog" + path: "/home/{{ fog_user }}/fog" owner: "{{ fog_user }}" state: directory diff --git a/roles/testnode/tasks/cpan.yml b/roles/testnode/tasks/cpan.yml index 0536246..2925c8d 100644 --- a/roles/testnode/tasks/cpan.yml +++ b/roles/testnode/tasks/cpan.yml @@ -34,7 +34,7 @@ mode: 0755 - name: Ensure perl-doc and cpanminus is installed on apt systems. - apt: name={{item}} state=present + apt: name={{ item }} state=present with_items: - cpanminus - perl-doc diff --git a/roles/testnode/tasks/ntp.yml b/roles/testnode/tasks/ntp.yml index 9ec8f40..f93bef2 100644 --- a/roles/testnode/tasks/ntp.yml +++ b/roles/testnode/tasks/ntp.yml @@ -49,7 +49,7 @@ - name: Make sure ntpd is running. service: - name: "{{ntp_service_name}}" + name: "{{ ntp_service_name }}" enabled: yes state: started # There's an issue with ansible<=2.9 and our custom built kernels (5.8 as of this commit) where the service and systemd modules don't have backwards compatibility with init scripts diff --git a/roles/users/tasks/filter_users.yml b/roles/users/tasks/filter_users.yml index 280f1ac..8c7124d 100644 --- a/roles/users/tasks/filter_users.yml +++ b/roles/users/tasks/filter_users.yml @@ -18,7 +18,7 @@ # in managed_admin_users managed_users: "[{% for lab_user in managed_users -%} - {% if not managed_admin_users|selectattr('name', 'equalto', lab_user.name)|list|length %}{{ lab_user}},{% endif %} + {% if not managed_admin_users|selectattr('name', 'equalto', lab_user.name)|list|length %}{{ lab_user }},{% endif %} {%- endfor %}]" when: extra_admin_users is defined and extra_admin_users|length > 0