From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Fri, 10 May 2013 11:07:24 +0000 (+0200)
Subject: libcephfs/test.cc: add assert for result of ceph_getxattr()
X-Git-Tag: v0.63~41^2~16
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=0c70e44630734760fd36e0c770a33fb0e74b42a4;p=ceph.git

libcephfs/test.cc: add assert for result of ceph_getxattr()

Check result of ceph_getxattr() before pass it as parameter to
strncmp(). Make sure it's not negative.

CID 739411 Argument cannot be negative (CWE-687)

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/test/libcephfs/test.cc b/src/test/libcephfs/test.cc
index 6022fc5e06a9..7ecf536fb99a 100644
--- a/src/test/libcephfs/test.cc
+++ b/src/test/libcephfs/test.cc
@@ -436,6 +436,7 @@ TEST(LibCephFS, Xattrs) {
 
     char gxattrv[128];
     int alen = ceph_getxattr(cmount, test_xattr_file, p, (void *) gxattrv, 128);
+    ASSERT_LT(alen, 0);
     sprintf(xattrv, "testxattr%c", i);
     ASSERT_TRUE(!strncmp(xattrv, gxattrv, alen));