From: Zack Cerza <zack@redhat.com>
Date: Fri, 14 Jun 2024 18:51:20 +0000 (-0600)
Subject: suite.Run.schedule_jobs: Unmask error in dry-run
X-Git-Tag: 1.2.0~35^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=0da32ffff8511b5309d7d9e790136aa52d606e72;p=teuthology.git

suite.Run.schedule_jobs: Unmask error in dry-run

For whatever reason we were suppressing an error related to unavailable
packages.

Signed-off-by: Zack Cerza <zack@redhat.com>
---

diff --git a/teuthology/suite/run.py b/teuthology/suite/run.py
index a37887811..8fa45b5b4 100644
--- a/teuthology/suite/run.py
+++ b/teuthology/suite/run.py
@@ -512,13 +512,10 @@ class Run(object):
             log_prefix = ''
             if job in jobs_missing_packages:
                 log_prefix = "Missing Packages: "
-                if (
-                    not self.args.dry_run and
-                    not config.suite_allow_missing_packages
-                ):
+                if not config.suite_allow_missing_packages:
                     util.schedule_fail(
-                        "At least one job needs packages that don't exist for "
-                        "hash {sha1}.".format(sha1=self.base_config.sha1),
+                        "At least one job needs packages that don't exist "
+                        f"for hash {self.base_config.sha1}.",
                         name,
                         dry_run=self.args.dry_run,
                     )