From: Kefu Chai <kchai@redhat.com>
Date: Mon, 22 Jul 2019 09:33:56 +0000 (+0800)
Subject: msg/Message: remove unused local variables
X-Git-Tag: v15.1.0~2126^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=0e93acad3ede7310dc0ab8851f1243953f72959e;p=ceph-ci.git

msg/Message: remove unused local variables

and avoid creating a temporary instance of `ceph_msg_footer`.

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/msg/Message.cc b/src/msg/Message.cc
index 802c73d7a63..50982e6181d 100644
--- a/src/msg/Message.cc
+++ b/src/msg/Message.cc
@@ -957,15 +957,12 @@ void Message::decode_trace(bufferlist::const_iterator &p, bool create)
 
 void encode_message(Message *msg, uint64_t features, bufferlist& payload)
 {
-  bufferlist front, middle, data;
   ceph_msg_footer_old old_footer;
-  ceph_msg_footer footer;
   msg->encode(features, MSG_CRC_ALL);
   encode(msg->get_header(), payload);
 
   // Here's where we switch to the old footer format.  PLR
-
-  footer = msg->get_footer();
+  ceph_msg_footer footer = msg->get_footer();
   old_footer.front_crc = footer.front_crc;   
   old_footer.middle_crc = footer.middle_crc;   
   old_footer.data_crc = footer.data_crc;