From: John Spray <john.spray@redhat.com>
Date: Mon, 28 Aug 2017 12:50:46 +0000 (+0100)
Subject: mds: fix "1 filesystem is have a..." message
X-Git-Tag: v12.2.1~57^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=0ec531240ad47dc2d11db68a50d7e9debfe67efe;p=ceph.git

mds: fix "1 filesystem is have a..." message

Like "Health check failed: 1 filesystem is have a failed mds daemon (FS_WITH_FAILED_MDS)"

Fixes: http://tracker.ceph.com/issues/21153
Signed-off-by: John Spray <john.spray@redhat.com>
(cherry picked from commit 7d21119a47212140d121df99efdb838a3f078a82)
---

diff --git a/src/mds/FSMap.cc b/src/mds/FSMap.cc
index c605dfcd1571..95e78b234257 100644
--- a/src/mds/FSMap.cc
+++ b/src/mds/FSMap.cc
@@ -355,7 +355,7 @@ void FSMap::get_health_checks(health_check_map_t *checks) const
     if (!stuck_failed.empty()) {
       health_check_t& fscheck = checks->get_or_add(
         "FS_WITH_FAILED_MDS", HEALTH_WARN,
-        "%num% filesystem%plurals% %isorare% have a failed mds daemon");
+        "%num% filesystem%plurals% %hasorhave% a failed mds daemon");
       ostringstream ss;
       ss << "fs " << fs->mds_map.fs_name << " has " << stuck_failed.size()
          << " failed mds" << (stuck_failed.size() > 1 ? "s" : "");
diff --git a/src/mon/MDSMonitor.cc b/src/mon/MDSMonitor.cc
index 9d0b50d18cfb..f38c1e91fd95 100644
--- a/src/mon/MDSMonitor.cc
+++ b/src/mon/MDSMonitor.cc
@@ -234,6 +234,10 @@ void MDSMonitor::encode_pending(MonitorDBStore::TransactionRef t)
       p.second.summary,
       boost::regex("%isorare%"),
       p.second.detail.size() > 1 ? "are" : "is");
+    p.second.summary = boost::regex_replace(
+      p.second.summary,
+      boost::regex("%hasorhave%"),
+      p.second.detail.size() > 1 ? "have" : "has");
   }
   encode_health(new_checks, t);
 }