From: Colin Patrick McCabe <cmccabe@alumni.cmu.edu>
Date: Wed, 23 Feb 2011 13:50:10 +0000 (-0800)
Subject: Fold common_set_defaults into common_init
X-Git-Tag: v0.25~45^2~23
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=0f90d1564e13d398331bc6e321355257283a062d;p=ceph.git

Fold common_set_defaults into common_init

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
---

diff --git a/src/cauthtool.cc b/src/cauthtool.cc
index 786d98c58cab..1cb80b1e5f11 100644
--- a/src/cauthtool.cc
+++ b/src/cauthtool.cc
@@ -53,7 +53,6 @@ int main(int argc, const char **argv)
   env_to_vec(args);
   DEFINE_CONF_VARS(usage);
 
-  common_set_defaults(false);
   common_init(args, "cauthtool", STARTUP_FLAG_FORCE_FG_LOGGING);
 
   const char *me = argv[0];
diff --git a/src/cconf.cc b/src/cconf.cc
index cb25aadb6713..668738d73675 100644
--- a/src/cconf.cc
+++ b/src/cconf.cc
@@ -150,7 +150,6 @@ int main(int argc, const char **argv)
     }
   }
 
-  common_set_defaults(false);
   common_init(nargs, type, STARTUP_FLAG_FORCE_FG_LOGGING);
 
   if (do_help) {
diff --git a/src/cfuse.cc b/src/cfuse.cc
index cceed5bbec5a..314b3309959a 100644
--- a/src/cfuse.cc
+++ b/src/cfuse.cc
@@ -53,8 +53,8 @@ int main(int argc, const char **argv, const char *envp[]) {
   argv_to_vec(argc, argv, args);
   env_to_vec(args);
 
-  common_set_defaults(false);
   g_conf.daemonize = true;
+  g_conf.pid_file = 0;
   g_conf.log_per_instance = true;
   common_init(args, "cfuse", STARTUP_FLAG_INIT_KEYS);
 
diff --git a/src/cmds.cc b/src/cmds.cc
index 03de4414781a..f0483d9fe1d0 100644
--- a/src/cmds.cc
+++ b/src/cmds.cc
@@ -65,7 +65,6 @@ int main(int argc, const char **argv)
   argv_to_vec(argc, argv, args);
   env_to_vec(args);
 
-  common_set_defaults(true);
 #ifdef HAVE_LIBTCMALLOC
   g_conf.profiler_start = HeapProfilerStart;
   g_conf.profiler_running = IsHeapProfilerRunning;
@@ -73,7 +72,7 @@ int main(int argc, const char **argv)
   g_conf.profiler_dump = HeapProfilerDump;
   g_conf.tcmalloc_have = true;
 #endif //HAVE_LIBTCMALLOC
-  common_init(args, "mds", STARTUP_FLAG_INIT_KEYS);
+  common_init(args, "mds", STARTUP_FLAG_INIT_KEYS | STARTUP_FLAG_DAEMON);
 
   // mds specific args
   int shadow = 0;
diff --git a/src/cmon.cc b/src/cmon.cc
index 8093ed5f3c5e..e0959c87700d 100644
--- a/src/cmon.cc
+++ b/src/cmon.cc
@@ -61,8 +61,7 @@ int main(int argc, const char **argv)
   argv_to_vec(argc, argv, args);
   env_to_vec(args);
 
-  common_set_defaults(true);
-  common_init(args, "mon", STARTUP_FLAG_INIT_KEYS);
+  common_init(args, "mon", STARTUP_FLAG_INIT_KEYS | STARTUP_FLAG_DAEMON);
 
   FOR_EACH_ARG(args) {
     if (CONF_ARG_EQ("mkfs", '\0')) {
diff --git a/src/common/common_init.cc b/src/common/common_init.cc
index 300ef9c93212..ef170471b5eb 100644
--- a/src/common/common_init.cc
+++ b/src/common/common_init.cc
@@ -54,18 +54,6 @@ void set_foreground_logging()
   g_conf.log_to_file = false;
 }
 
-void common_set_defaults(bool daemon)
-{
-  if (daemon) {
-    cout << TEXT_YELLOW << " ** WARNING: Ceph is still under heavy development, and is only suitable for **" << TEXT_NORMAL << std::endl;
-    cout << TEXT_YELLOW <<  " **          testing and review.  Do not trust it with important data.       **" << TEXT_NORMAL << std::endl;
-
-    g_conf.daemonize = true;
-  } else {
-    g_conf.pid_file = 0;
-  }
-}
-
 static void keyring_init(const char *filesearch)
 {
   const char *filename = filesearch;
@@ -121,6 +109,18 @@ static void keyring_init(const char *filesearch)
 void common_init(std::vector<const char*>& args, const char *module_type, int flags)
 {
   bool force_fg_logging = false;
+
+  if (flags & STARTUP_FLAG_DAEMON) {
+    cout << TEXT_YELLOW << " ** WARNING: Ceph is still under heavy development, "
+         << "and is only suitable for **" << TEXT_NORMAL << std::endl;
+    cout << TEXT_YELLOW <<  " **          testing and review.  Do not trust it "
+         << "with important data.       **" << TEXT_NORMAL << std::endl;
+    g_conf.daemonize = true;
+  }
+  else {
+    g_conf.pid_file = 0;
+  }
+
   parse_startup_config_options(args, module_type, flags, &force_fg_logging);
 
   if (g_conf.log_to_syslog || g_conf.clog_to_syslog) {
diff --git a/src/common/common_init.h b/src/common/common_init.h
index 428adffc60e2..8d3b06ee9b27 100644
--- a/src/common/common_init.h
+++ b/src/common/common_init.h
@@ -6,9 +6,9 @@
 enum {
   STARTUP_FLAG_INIT_KEYS =                      0x01,
   STARTUP_FLAG_FORCE_FG_LOGGING =               0x02,
+  STARTUP_FLAG_DAEMON =                         0x04,
 };
 
-void common_set_defaults(bool daemon);
 void common_init(std::vector<const char*>& args,
 		 const char *module_type,
                  int flags);
diff --git a/src/cosd.cc b/src/cosd.cc
index 464b73967fa1..2fbcb169076c 100644
--- a/src/cosd.cc
+++ b/src/cosd.cc
@@ -52,7 +52,7 @@ int main(int argc, const char **argv)
   vector<const char*> args;
   argv_to_vec(argc, argv, args);
   env_to_vec(args);
-  int startup_flags = STARTUP_FLAG_INIT_KEYS;
+  int startup_flags = STARTUP_FLAG_INIT_KEYS | STARTUP_FLAG_DAEMON;
   vector<const char *>::iterator args_iter;
 
   for (args_iter = args.begin(); args_iter != args.end(); ++args_iter) {
@@ -62,7 +62,6 @@ int main(int argc, const char **argv)
     } 
   }
 
-  common_set_defaults(true);
 #ifdef HAVE_LIBTCMALLOC
   g_conf.profiler_start = HeapProfilerStart;
   g_conf.profiler_running = IsHeapProfilerRunning;
diff --git a/src/csyn.cc b/src/csyn.cc
index 26c5baacd770..bad7e7f6dfe5 100644
--- a/src/csyn.cc
+++ b/src/csyn.cc
@@ -46,7 +46,6 @@ int main(int argc, const char **argv, char *envp[])
   vector<const char*> args;
   argv_to_vec(argc, argv, args);
 
-  common_set_defaults(false);
   common_init(args, "csyn",
 	      STARTUP_FLAG_INIT_KEYS | STARTUP_FLAG_FORCE_FG_LOGGING);
 
diff --git a/src/dumpjournal.cc b/src/dumpjournal.cc
index 8fe581f8c282..6680cb0d7817 100644
--- a/src/dumpjournal.cc
+++ b/src/dumpjournal.cc
@@ -81,7 +81,6 @@ int main(int argc, const char **argv, const char *envp[])
   argv_to_vec(argc, argv, args);
   env_to_vec(args);
 
-  common_set_defaults(false);
   common_init(args, "dumpjournal", STARTUP_FLAG_FORCE_FG_LOGGING);
 
   vec_to_argv(args, argc, argv);
diff --git a/src/dupstore.cc b/src/dupstore.cc
index ccbcb359b3af..d66da408aaee 100644
--- a/src/dupstore.cc
+++ b/src/dupstore.cc
@@ -88,7 +88,6 @@ int main(int argc, const char **argv)
   argv_to_vec(argc, argv, args);
   env_to_vec(args);
 
-  common_set_defaults(false);
   common_init(args, "dumpstore", STARTUP_FLAG_FORCE_FG_LOGGING);
 
   // args
diff --git a/src/libceph.cc b/src/libceph.cc
index 705ffed26877..7fc0a984c606 100644
--- a/src/libceph.cc
+++ b/src/libceph.cc
@@ -43,7 +43,6 @@ extern "C" int ceph_initialize(int argc, const char **argv)
     //create everything to start a client
     vector<const char*> args;
     argv_to_vec(argc, argv, args);
-    common_set_defaults(false);
     common_init(args, "libceph", STARTUP_FLAG_INIT_KEYS);
     //monmap
     monclient = new MonClient();
diff --git a/src/librados-config.cc b/src/librados-config.cc
index 5c788009a013..12f58f1517d9 100644
--- a/src/librados-config.cc
+++ b/src/librados-config.cc
@@ -57,7 +57,6 @@ int main(int argc, const char **argv)
       ++i;
   }
 
-  common_set_defaults(false);
   common_init(args, "librados-config", STARTUP_FLAG_FORCE_FG_LOGGING);
 
   FOR_EACH_ARG(args) {
diff --git a/src/librados.cc b/src/librados.cc
index 3fb7dae02a62..2f8b93ecca33 100644
--- a/src/librados.cc
+++ b/src/librados.cc
@@ -1824,7 +1824,6 @@ int Rados::initialize(int argc, const char *argv[])
     argv_to_vec(argc, argv, args);
     env_to_vec(args);
   }
-  common_set_defaults(false);
   common_init(args, "librados", STARTUP_FLAG_INIT_KEYS);
 
   return 0;
@@ -2361,7 +2360,6 @@ extern "C" int rados_create(rados_t *pcluster)
     vector<const char*> args;
     env_to_vec(args);
 
-    common_set_defaults(false);
     common_init(args, "librados", STARTUP_FLAG_INIT_KEYS);
 
     ++rados_initialized;
diff --git a/src/osdmaptool.cc b/src/osdmaptool.cc
index 05881ab84ef0..4767887f9427 100644
--- a/src/osdmaptool.cc
+++ b/src/osdmaptool.cc
@@ -49,7 +49,6 @@ int main(int argc, const char **argv)
   env_to_vec(args);
   DEFINE_CONF_VARS(usage);
 
-  common_set_defaults(false);
   common_init(args, "osdmaptool", STARTUP_FLAG_FORCE_FG_LOGGING);
 
   const char *me = argv[0];
diff --git a/src/rados.cc b/src/rados.cc
index 02f41201e246..94a06ef4df88 100644
--- a/src/rados.cc
+++ b/src/rados.cc
@@ -97,7 +97,6 @@ int main(int argc, const char **argv)
   argv_to_vec(argc, argv, args);
   env_to_vec(args);
 
-  common_set_defaults(false);
   common_init(args, "rados",
 	      STARTUP_FLAG_FORCE_FG_LOGGING | STARTUP_FLAG_INIT_KEYS);
 
diff --git a/src/rbd.cc b/src/rbd.cc
index b95675c40cb0..fae59d9e2902 100644
--- a/src/rbd.cc
+++ b/src/rbd.cc
@@ -576,7 +576,6 @@ int main(int argc, const char **argv)
   env_to_vec(args);
 
   int opt_cmd = OPT_NO_CMD;
-  common_set_defaults(false);
   common_init(args, "rbd",
 	      STARTUP_FLAG_FORCE_FG_LOGGING | STARTUP_FLAG_INIT_KEYS);
 
diff --git a/src/rgw/rgw_admin.cc b/src/rgw/rgw_admin.cc
index 4c46419ab2d7..31671e41a3c0 100644
--- a/src/rgw/rgw_admin.cc
+++ b/src/rgw/rgw_admin.cc
@@ -83,7 +83,6 @@ int main(int argc, char **argv)
   argv_to_vec(argc, (const char **)argv, args);
   env_to_vec(args);
 
-  common_set_defaults(false);
   common_init(args, "rgw",
 	      STARTUP_FLAG_FORCE_FG_LOGGING | STARTUP_FLAG_INIT_KEYS);
 
diff --git a/src/streamtest.cc b/src/streamtest.cc
index 1a6261ba0d0f..105fabfc4047 100644
--- a/src/streamtest.cc
+++ b/src/streamtest.cc
@@ -97,7 +97,6 @@ int main(int argc, const char **argv)
   argv_to_vec(argc, argv, args);
   env_to_vec(args);
 
-  common_set_defaults(false);
   common_init(args, NULL,
 	      STARTUP_FLAG_FORCE_FG_LOGGING | STARTUP_FLAG_INIT_KEYS);
 
diff --git a/src/test/TestDoutStreambuf.cc b/src/test/TestDoutStreambuf.cc
index 0ac1a3d48d7c..12e15c5a283a 100644
--- a/src/test/TestDoutStreambuf.cc
+++ b/src/test/TestDoutStreambuf.cc
@@ -36,7 +36,6 @@ int main(int argc, const char **argv)
   argv_to_vec(argc, argv, args);
   env_to_vec(args);
 
-  common_set_defaults(false);
   common_init(args, "ceph", STARTUP_FLAG_FORCE_FG_LOGGING);
 
   DoutStreambuf<char> *dos = new DoutStreambuf<char>();
diff --git a/src/test/TestSignalHandlers.cc b/src/test/TestSignalHandlers.cc
index 9283532816a5..8c364dae2fb4 100644
--- a/src/test/TestSignalHandlers.cc
+++ b/src/test/TestSignalHandlers.cc
@@ -94,7 +94,6 @@ int main(int argc, const char **argv)
   argv_to_vec(argc, argv, args);
   env_to_vec(args);
 
-  common_set_defaults(false);
   common_init(args, "TestSignalHandlers", STARTUP_FLAG_FORCE_FG_LOGGING);
 
   DEFINE_CONF_VARS(usage);
diff --git a/src/test/TestTimers.cc b/src/test/TestTimers.cc
index 1b96b6d45093..85f3041e49c4 100644
--- a/src/test/TestTimers.cc
+++ b/src/test/TestTimers.cc
@@ -255,7 +255,6 @@ int main(int argc, const char **argv)
   argv_to_vec(argc, argv, args);
   env_to_vec(args);
 
-  common_set_defaults(false);
   common_init(args, "ceph", STARTUP_FLAG_FORCE_FG_LOGGING);
 
   int ret;
diff --git a/src/test_trans.cc b/src/test_trans.cc
index ee631d2cb478..db9580a17605 100644
--- a/src/test_trans.cc
+++ b/src/test_trans.cc
@@ -36,7 +36,6 @@ int main(int argc, const char **argv)
   argv_to_vec(argc, argv, args);
   env_to_vec(args);
 
-  common_set_defaults(false);
   common_init(args, NULL, STARTUP_FLAG_FORCE_FG_LOGGING);
 
   // args
diff --git a/src/testmsgr.cc b/src/testmsgr.cc
index c92ef95e2167..1bb9ef11336f 100644
--- a/src/testmsgr.cc
+++ b/src/testmsgr.cc
@@ -70,7 +70,6 @@ int main(int argc, const char **argv, const char *envp[]) {
   argv_to_vec(argc, argv, args);
   env_to_vec(args);
 
-  common_set_defaults(false);
   common_init(args, NULL, STARTUP_FLAG_FORCE_FG_LOGGING);
 
   vec_to_argv(args, argc, argv);
diff --git a/src/tools/ceph.cc b/src/tools/ceph.cc
index b4c42e7853e0..bec3bd3671be 100644
--- a/src/tools/ceph.cc
+++ b/src/tools/ceph.cc
@@ -114,7 +114,6 @@ int main(int argc, const char **argv)
   argv_to_vec(argc, argv, args);
   env_to_vec(args);
 
-  common_set_defaults(false);
   common_init(args, "ceph",
 	      STARTUP_FLAG_INIT_KEYS | STARTUP_FLAG_FORCE_FG_LOGGING);
 
diff --git a/src/tools/gceph.cc b/src/tools/gceph.cc
index 930d9c714b5f..7fbb8f596502 100644
--- a/src/tools/gceph.cc
+++ b/src/tools/gceph.cc
@@ -75,7 +75,6 @@ int main(int argc, const char **argv)
   argv_to_vec(argc, argv, args);
   env_to_vec(args);
 
-  common_set_defaults(false);
   common_init(args, "cephtool",
 	      STARTUP_FLAG_FORCE_FG_LOGGING | STARTUP_FLAG_INIT_KEYS);