From: Kefu Chai Date: Wed, 20 Mar 2019 11:36:57 +0000 (+0800) Subject: Merge pull request #26701 from adamemerson/wip-trip-the-light-clangtastic X-Git-Tag: v15.0.0~178 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=10114f3375d4dfc039b5e901508e559e3f902b3f;p=ceph.git Merge pull request #26701 from adamemerson/wip-trip-the-light-clangtastic fix clang build failures, and clean up warnings Reviewed-by: Patrick Donnelly Reviewed-by: Sage Weil Reviewed-by: Kefu Chai --- 10114f3375d4dfc039b5e901508e559e3f902b3f diff --cc src/rgw/rgw_rados.cc index 1468457a3cb0,0c5e9ceba49c..1bca970f5707 --- a/src/rgw/rgw_rados.cc +++ b/src/rgw/rgw_rados.cc @@@ -2432,10 -2432,10 +2432,10 @@@ int RGWRados::Bucket::update_bucket_id( static inline std::string after_delim(std::string_view delim) { // assert: ! delim.empty() - char e = delim.back(); + unsigned char e = delim.back(); delim.remove_suffix(1); std::string result{delim.data(), delim.length()}; - if (e < 255) { + if (uint8_t(e) < 255) { result += char(++e); } else { result += e;