From: Samuel Just <sam.just@inktank.com>
Date: Wed, 29 Aug 2012 23:28:20 +0000 (-0700)
Subject: osd/PG.cc: PG constructor pass PGPool by reference
X-Git-Tag: v0.53~229^2~8
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=106367356e3a08a6991cbc6be9e51dffe76f9e87;p=ceph.git

osd/PG.cc: PG constructor pass PGPool by reference

CID 717053: Big parameter passed by value (PASS_BY_VALUE)At (1): Passing
parameter _pool of type PGPool (size 336 bytes) by value.

Signed-off-by: Samuel Just <sam.just@inktank.com>
---

diff --git a/src/osd/PG.cc b/src/osd/PG.cc
index 849dca4c3887..34e9d36ac6ee 100644
--- a/src/osd/PG.cc
+++ b/src/osd/PG.cc
@@ -57,7 +57,8 @@ void PGPool::update(OSDMapRef map)
 }
 
 PG::PG(OSDService *o, OSDMapRef curmap,
-       PGPool _pool, pg_t p, const hobject_t& loid, const hobject_t& ioid) :
+       const PGPool &_pool, pg_t p, const hobject_t& loid,
+       const hobject_t& ioid) :
   osd(o), osdmap_ref(curmap), pool(_pool),
   _lock("PG::_lock"),
   ref(0), deleting(false), dirty_info(false), dirty_log(false),
diff --git a/src/osd/PG.h b/src/osd/PG.h
index 2be781f47698..3acf4e73ca92 100644
--- a/src/osd/PG.h
+++ b/src/osd/PG.h
@@ -1395,7 +1395,7 @@ public:
 
  public:
   PG(OSDService *o, OSDMapRef curmap,
-     PGPool pool, pg_t p, const hobject_t& loid, const hobject_t& ioid);
+     const PGPool &pool, pg_t p, const hobject_t& loid, const hobject_t& ioid);
   virtual ~PG();
 
  private: