From: Jeff Layton <jlayton@kernel.org>
Date: Thu, 25 Aug 2022 13:31:10 +0000 (-0400)
Subject: ceph: update WARN_ON message to pr_warn
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=115af76bd83dcba16a453ff1ecc9493593d548d4;p=ceph-client.git

ceph: update WARN_ON message to pr_warn

Give some more helpful info

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---

diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
index 448125edd76b4..e09bc49809cf8 100644
--- a/fs/ceph/caps.c
+++ b/fs/ceph/caps.c
@@ -3503,10 +3503,13 @@ static void handle_cap_grant(struct inode *inode,
 		dout("%p mode 0%o uid.gid %d.%d\n", inode, inode->i_mode,
 		     from_kuid(&init_user_ns, inode->i_uid),
 		     from_kgid(&init_user_ns, inode->i_gid));
-
-		WARN_ON_ONCE(ci->fscrypt_auth_len != extra_info->fscrypt_auth_len ||
-			     memcmp(ci->fscrypt_auth, extra_info->fscrypt_auth,
-				     ci->fscrypt_auth_len));
+#if IS_ENABLED(CONFIG_FS_ENCRYPTION)
+		if (ci->fscrypt_auth_len != extra_info->fscrypt_auth_len ||
+		    memcmp(ci->fscrypt_auth, extra_info->fscrypt_auth,
+			   ci->fscrypt_auth_len))
+			pr_warn_ratelimited("%s: cap grant attempt to change fscrypt_auth on non-I_NEW inode (old len %d new len %d)\n",
+				__func__, ci->fscrypt_auth_len, extra_info->fscrypt_auth_len);
+#endif
 	}
 
 	if ((newcaps & CEPH_CAP_LINK_SHARED) &&