From: Guillaume Abrioux <gabrioux@redhat.com>
Date: Wed, 17 Jul 2019 13:55:12 +0000 (+0200)
Subject: validate: fail if gpt header found on unprepared devices
X-Git-Tag: v3.2.25~4
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=12e61d190e70951db33ff5a0b838316113efb1eb;p=ceph-ansible.git

validate: fail if gpt header found on unprepared devices

ceph-volume will complain if gpt headers are found on devices.
This commit checks whether a gpt header is present on devices passed in
`devices` variable and fail early.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1730541

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 487d7016850524af64254aa3a9ec61222ec926a4)
---

diff --git a/roles/ceph-validate/tasks/check_devices.yml b/roles/ceph-validate/tasks/check_devices.yml
index d8310490a..b6dc970c1 100644
--- a/roles/ceph-validate/tasks/check_devices.yml
+++ b/roles/ceph-validate/tasks/check_devices.yml
@@ -1,6 +1,21 @@
 ---
 - name: devices validation
   block:
+    - name: read information about the devices
+      parted:
+        device: "{{ item }}"
+        unit: MiB
+      register: parted_results
+      with_items: "{{ devices }}"
+
+    - name: fail when gpt header found on osd devices
+      fail:
+        msg: "{{ item.disk.dev }} has gpt header, please remove it."
+      with_items: "{{ parted_results.results }}"
+      when:
+        - item.disk.table == 'gpt'
+        - item.partitions | length == 0
+
     - name: get devices information
       parted:
         device: "{{ item }}"