From: Willem Jan Withagen <wjw@digiware.nl>
Date: Sun, 11 Apr 2021 14:27:35 +0000 (+0200)
Subject: test: Undo the FreeBSD specific retval test
X-Git-Tag: v17.1.0~2289^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=130dbc772526a4a2cee492252f3b73c3140dea8f;p=ceph.git

test: Undo the FreeBSD specific retval test

Changes to the socket code now result in returning EINVAL
In the past ENOENT was returned which is the FreeBSD error code
if DNS lookup does not work.

And that change is probably because somewhere in the code that
errorcode is not passed verbatim from the systemcall, but is
rewritten in extra evaluation.

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
---

diff --git a/src/test/mon/MonMap.cc b/src/test/mon/MonMap.cc
index c9bcb7fec083..81b054a9048f 100644
--- a/src/test/mon/MonMap.cc
+++ b/src/test/mon/MonMap.cc
@@ -237,9 +237,5 @@ TEST(MonMapBuildInitial, build_initial_mon_host_from_dns_fail) {
   cct->_conf.set_val("mon_host", "ceph.noname");
   MonMap monmap;
   int r = monmap.build_initial(cct.get(), false, std::cerr);
-#if defined(__FreeBSD__)
-  ASSERT_EQ(r, -ENOENT);
-#else
   ASSERT_EQ(r, -EINVAL);
-#endif
 }