From: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Date: Thu, 27 Oct 2022 13:23:42 +0000 (+0300)
Subject: test/librbd: enable the functional tests on Windows
X-Git-Tag: v19.0.0~672^2~2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=14d5c7cf8e3440a36eb980b0bfa632baad798f42;p=ceph-ci.git

test/librbd: enable the functional tests on Windows

Right now, the librbd tests are skipped on Windows.

This change enables the functional tests, which can run with
just a few modifications.

We'll continue skipping the unit tests however, which require
too much OSD code that hasn't been ported (e.g. cls, libosd, etc).

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
---

diff --git a/src/test/CMakeLists.txt b/src/test/CMakeLists.txt
index 841b7ffa6ca..09281ab2dbf 100644
--- a/src/test/CMakeLists.txt
+++ b/src/test/CMakeLists.txt
@@ -22,11 +22,9 @@ add_subdirectory(librados_test_stub)
 if(WITH_LIBRADOSSTRIPER)
   add_subdirectory(libradosstriper)
 endif()
-if(WITH_RBD AND NOT WIN32)
-  # librbd tests require libcls*, which in turn require libos and libosd, which
-  # haven't been ported to Windows yet.
+if(WITH_RBD)
   add_subdirectory(librbd)
-endif(WITH_RBD AND NOT WIN32)
+endif()
 if (WITH_CEPHFS)
   add_subdirectory(mds)
 endif()
diff --git a/src/test/librbd/CMakeLists.txt b/src/test/librbd/CMakeLists.txt
index 87984bd94a9..0ae29b8bf18 100644
--- a/src/test/librbd/CMakeLists.txt
+++ b/src/test/librbd/CMakeLists.txt
@@ -152,6 +152,11 @@ if(LINUX AND HAVE_LIBCRYPTSETUP)
           crypto/luks/test_mock_LoadRequest.cc)
 endif()
 
+# On Windows, we'll skip librbd unit tests for the time being, running just the
+# functional tests. The reason is that the unit tests require libcls*, which in
+# turn requires libos and libosd, however those libraries haven't been ported to
+# Windows.
+if(NOT WIN32)
 add_executable(unittest_librbd
   ${unittest_librbd_srcs}
   $<TARGET_OBJECTS:common_texttable_obj>)
@@ -187,6 +192,7 @@ if(WITH_RBD_RWL OR WITH_RBD_SSD_CACHE)
   target_link_libraries(unittest_librbd
     librbd_plugin_pwl_cache)
 endif()
+endif(NOT WIN32)
 
 add_executable(ceph_test_librbd
   test_main.cc