From: amitkuma <amitkuma@redhat.com>
Date: Tue, 7 Nov 2017 17:00:27 +0000 (+0530)
Subject: mon: NULL check of logger before use
X-Git-Tag: v13.0.2~594^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=150288efa720a955d830e783263d41b4da946711;p=ceph.git

mon: NULL check of logger before use

Fixes the coverity issue:
CID 1316234 (#1 of 1): Dereference after null check (FORWARD_NULL)
6. var_deref_model: remove_session dereferences null this->logger

Signed-off-by: Amit Kumar <amitkuma@redhat.com>
---

diff --git a/src/mon/Monitor.cc b/src/mon/Monitor.cc
index 41b19bb6a78..f53cf7c3d5e 100644
--- a/src/mon/Monitor.cc
+++ b/src/mon/Monitor.cc
@@ -3832,8 +3832,7 @@ void Monitor::remove_all_sessions()
   while (!session_map.sessions.empty()) {
     MonSession *s = session_map.sessions.front();
     remove_session(s);
-    if (logger)
-      logger->inc(l_mon_session_rm);
+    logger->inc(l_mon_session_rm);
   }
   if (logger)
     logger->set(l_mon_num_sessions, session_map.get_size());