From: Kefu Chai Date: Mon, 16 Aug 2021 09:26:09 +0000 (+0800) Subject: rgw/rgw_rest: do not set unused variable X-Git-Tag: v17.1.0~1111^2~3 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=164fb13fc93680d92adebdc0115ae0c546db84d3;p=ceph.git rgw/rgw_rest: do not set unused variable `len` is used to track the total length of received data, but we already collect the data in `bl`, so we can always check `bl` for the total length. this change also silences following warning from Clang: ../src/rgw/rgw_rest.cc:1477:21: warning: variable 'len' set but not used [-Wunused-but-set-variable] int read_len = 0, len = 0; ^ 1 warning generated. Signed-off-by: Kefu Chai --- diff --git a/src/rgw/rgw_rest.cc b/src/rgw/rgw_rest.cc index a07bd2500b9b..c3389a43e28d 100644 --- a/src/rgw/rgw_rest.cc +++ b/src/rgw/rgw_rest.cc @@ -1474,7 +1474,7 @@ static std::tuple read_all_chunked_input(req_state *s, const ui int total = need_to_read; bufferlist bl; - int read_len = 0, len = 0; + int read_len = 0; do { bufferptr bp(need_to_read + 1); read_len = recv_body(s, bp.c_str(), need_to_read); @@ -1485,7 +1485,6 @@ static std::tuple read_all_chunked_input(req_state *s, const ui bp.c_str()[read_len] = '\0'; bp.set_length(read_len); bl.append(bp); - len += read_len; if (read_len == need_to_read) { if (need_to_read < MAX_READ_CHUNK)