From: amitkuma <amitkuma@redhat.com>
Date: Wed, 23 Aug 2017 17:14:34 +0000 (+0530)
Subject: test: Checking fd for negative before closing
X-Git-Tag: v13.0.0~8^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=1666d9aa81045d6ee23fade338fcde69ace2a4c1;p=ceph.git

test: Checking fd for negative before closing

Fixes the coverity issue:

** 1395317 Argument cannot be negative
161. negative_return_fn: Function open("bufferlist", 0) returns a
negative number.
162. var_assign: Assigning: signed variable fd = open.

Signed-off-by: Amit Kumar amitkuma@redhat.com
---

diff --git a/src/test/bufferlist.cc b/src/test/bufferlist.cc
index 53d66a036c8b..4d454ab7ccd7 100644
--- a/src/test/bufferlist.cc
+++ b/src/test/bufferlist.cc
@@ -219,6 +219,7 @@ TEST(Buffer, constructors) {
     snprintf(cmd, sizeof(cmd), "echo ABC > %s", FILENAME);
     EXPECT_EQ(0, ::system(cmd));
     int fd = ::open(FILENAME, O_RDONLY);
+    assert (fd >= 0);
     bufferptr ptr(buffer::create_zero_copy(zc_len, fd, NULL));
     history_alloc_bytes += zc_len;
     history_alloc_num++;