From: Ilya Dryomov <idryomov@gmail.com>
Date: Thu, 10 Apr 2025 21:11:38 +0000 (+0200)
Subject: cls/rbd: drop overzealous CLS_ERR message in mirror_remote_namespace_get()
X-Git-Tag: testing/wip-rishabh-testing-20250411.152937-debug~4^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=1684f010e0a2f72cdc18d7cc56fbde7c418c4d37;p=ceph-ci.git

cls/rbd: drop overzealous CLS_ERR message in mirror_remote_namespace_get()

Currently it unnecessarily floods the log of the OSD which hosts
rbd_mirroring object with "No such file or directory" errors.  Just
drop it as read_key() already logs all errors except ENOENT.

Credit to N Balachandran <nibalach@redhat.com> for spotting this.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
---

diff --git a/src/cls/rbd/cls_rbd.cc b/src/cls/rbd/cls_rbd.cc
index b6e2af50064..7c0cd1f1266 100644
--- a/src/cls/rbd/cls_rbd.cc
+++ b/src/cls/rbd/cls_rbd.cc
@@ -5938,8 +5938,6 @@ int mirror_remote_namespace_get(cls_method_context_t hctx, bufferlist *in,
   std::string mirror_ns_decode;
   int r = read_key(hctx, mirror::REMOTE_NAMESPACE, &mirror_ns_decode);
   if (r < 0) {
-    CLS_ERR("error getting mirror remote namespace: %s",
-            cpp_strerror(r).c_str());
     return r;
   }