From: Sage Weil <sage@redhat.com>
Date: Wed, 6 Jan 2016 22:59:58 +0000 (-0500)
Subject: os/bluestore: remove #warning cruft
X-Git-Tag: v10.0.3~88^2~8
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=16e9cb9334bd6c9dfe16cdeaead321292956a62c;p=ceph.git

os/bluestore: remove #warning cruft

These are on my todo list elsewhere.

Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/src/os/bluestore/BlockDevice.cc b/src/os/bluestore/BlockDevice.cc
index 33370bf4950..34f4be8598a 100644
--- a/src/os/bluestore/BlockDevice.cc
+++ b/src/os/bluestore/BlockDevice.cc
@@ -435,8 +435,6 @@ int BlockDevice::aio_zero(
   assert(off < size);
   assert(off + len <= size);
 
-#warning fix discard (aio?)
-  //return fs->zero(fd, off, len);
   bufferlist bl;
   while (len > 0) {
     bufferlist t;
diff --git a/src/os/bluestore/BlueFS.cc b/src/os/bluestore/BlueFS.cc
index 03eb0507ade..e2d41ba937d 100644
--- a/src/os/bluestore/BlueFS.cc
+++ b/src/os/bluestore/BlueFS.cc
@@ -785,7 +785,6 @@ void BlueFS::_maybe_compact_log()
 
 void BlueFS::_compact_log()
 {
-#warning smarter _compact_log
   // FIXME: we currently hold the lock while writing out the compacted log,
   // which may mean a latency spike.  we could drop the lock while writing out
   // the big compacted log, while continuing to log at the end of the old log
diff --git a/src/os/bluestore/BlueStore.cc b/src/os/bluestore/BlueStore.cc
index ce3b3f70c41..ca833de1cf9 100644
--- a/src/os/bluestore/BlueStore.cc
+++ b/src/os/bluestore/BlueStore.cc
@@ -1443,8 +1443,7 @@ int BlueStore::_balance_bluefs_freespace(vector<bluestore_extent_t> *extents)
     }
   }
 
-// reclaim?
-#warning reclaim freespace from bluefs?
+  // FIXME: reclaim from bluefs?
 
   return ret;
 }
@@ -4281,7 +4280,6 @@ int BlueStore::_do_write_overlays(TransContext *txc,
     return 0;
 
   assert(0 == "this is all broken");
-#warning overlays are broken
 
   uint64_t min_alloc_size = g_conf->bluestore_min_alloc_size;
 
@@ -4345,7 +4343,6 @@ int BlueStore::_do_write_overlays(TransContext *txc,
 			   &cow_rmw_head, &cow_rmw_tail);
       if (r < 0)
 	return r;
-#warning fixme rmw cow?
       bp = o->onode.find_extent(offset);
       if (bp->second.has_flag(bluestore_extent_t::FLAG_UNWRITTEN)) {
 	dout(10) << __func__ << " zero new allocation " << bp->second << dendl;